Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: context path #4437

Open
2 tasks done
jclab-joseph opened this issue Oct 6, 2023 · 2 comments
Open
2 tasks done

🚀 Feature: context path #4437

jclab-joseph opened this issue Oct 6, 2023 · 2 comments
Labels

Comments

@jclab-joseph
Copy link

jclab-joseph commented Oct 6, 2023

🔖 Feature description

Make novu web accessible through context path.

Currently, GLOBAL_CONTEXT_PATH exists in the API service, so the API can operate.
However, in the case of web, the context path cannot be set before rebuilding.
It would be nice to be able to change the context path with an environment variable.

🎤 Why is this feature needed ?

This is required when multi-domain cannot be used.

✌️ How do you aim to achieve this?

Make context-path configurable for all api, web, and ws through the GLOBAL_CONTEXT_PATH environment variable.

🔄️ Additional Information

There is FRONT_BASE_CONTEXT_PATH, but it doesn't seem to be used properly.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@github-actions github-actions bot added the triage label Oct 6, 2023
@parag477
Copy link

parag477 commented Oct 8, 2023

I want to work on this.

@jclab-joseph
Copy link
Author

jclab-joseph commented Oct 9, 2023

@parag477

https://docs.novu.co/community/run-in-local-machine
This article will help you run it locally!
I also tried to create a PR but gave up. (I don't know how to modify react and http-server to beautifully). But you can do it!

To solve this issue need two things:

  • Make it possible to dynamically convert the baseUrl of React's router (you can probably use the env.js that already exists).
  • Make it possible to set the context path on the http-server when serving files from the built frontend. Also, the addresses of assets referenced in index.html should be dynamically replaced.

(https://github.com/novuhq/novu/blob/next/apps/web/package.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants