Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2932] Fix the pseudo class ":first-child" warning shown in the console #4293

Closed
LetItRock opened this issue Oct 1, 2023 · 13 comments · Fixed by #4298
Closed

[NV-2932] Fix the pseudo class ":first-child" warning shown in the console #4293

LetItRock opened this issue Oct 1, 2023 · 13 comments · Fixed by #4298
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@LetItRock
Copy link
Contributor

Reproduction Steps

  1. Navigate to the Workflows page
  2. Open any workflow
  3. The warning is shown: The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type". is printed in the console.

image

Expected Behaviour

  • fix the issue and there should be no warnings printed
@LetItRock LetItRock added bug Something isn't working good first issue Good for newcomers Hacktoberfest labels Oct 1, 2023
@LetItRock LetItRock changed the title [NV-2932] Fix the warning shown in the console [NV-2932] Fix the pseudo class ":first-child" warning shown in the console Oct 1, 2023
@Ryan-Maddock-96
Copy link

Can I take a look at this please? :)

@LetItRock
Copy link
Contributor Author

LetItRock commented Oct 1, 2023

Can I take a look at this please? :)

thanks @Ryan-Maddock-96! 🤝 the ticket is yours ;)

@Ryan-Maddock-96
Copy link

Thank you! I'll get on it right away

@Ryan-Maddock-96
Copy link

Sorry struggling to get the project running locally I know what change needs to be made obviously just can't test it :(

@UzairNoman
Copy link
Contributor

@Ryan-Maddock-96, try to follow this documentation:

https://docs.novu.co/community/run-in-local-machine

This will help for sure.

@LetItRock
Copy link
Contributor Author

@Ryan-Maddock-96 please take a look at the documentation listed above, in case you still having some problems please share them here or on our discord channel ;)

@Ryan-Maddock-96
Copy link

Okay I'll have a look at the documentation now sorry was at work :D

@Ryan-Maddock-96
Copy link

@LetItRock is there not a quick way of getting it up and running without downloading everything lol seems a long winded process when all I need to see is if changing :first-child to :first-of-type works :D

@Shivam-043
Copy link

@LetItRock i want to work over this , if it is not resolved still !

@Ryan-Maddock-96
Copy link

I'm happy for @Shivam-043 to take it unfortunately I'm struggling with the setup sorry!

@UzairNoman
Copy link
Contributor

@LetItRock, I have already submitted the PR some days ago. I'd be really happy if you could review my PR (#4298). As you mentioned in the PR, that if the original person couldn't finish the task, you will revisit my PR. Thanks in advance :)

@Ryan-Maddock-96
Copy link

Its a shame I was obviously going to do the same change as you but didn't want to presume it worked without testing it

@LetItRock
Copy link
Contributor Author

hey @UzairNoman 👋 assigned the ticket to you, we will check your PR soon ;) thanks a lot! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants