-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NV-2932] Fix the pseudo class ":first-child" warning shown in the console #4293
Comments
Can I take a look at this please? :) |
thanks @Ryan-Maddock-96! 🤝 the ticket is yours ;) |
Thank you! I'll get on it right away |
Sorry struggling to get the project running locally I know what change needs to be made obviously just can't test it :( |
@Ryan-Maddock-96, try to follow this documentation: https://docs.novu.co/community/run-in-local-machine This will help for sure. |
@Ryan-Maddock-96 please take a look at the documentation listed above, in case you still having some problems please share them here or on our discord channel ;) |
Okay I'll have a look at the documentation now sorry was at work :D |
@LetItRock is there not a quick way of getting it up and running without downloading everything lol seems a long winded process when all I need to see is if changing :first-child to :first-of-type works :D |
@LetItRock i want to work over this , if it is not resolved still ! |
I'm happy for @Shivam-043 to take it unfortunately I'm struggling with the setup sorry! |
@LetItRock, I have already submitted the PR some days ago. I'd be really happy if you could review my PR (#4298). As you mentioned in the PR, that if the original person couldn't finish the task, you will revisit my PR. Thanks in advance :) |
Its a shame I was obviously going to do the same change as you but didn't want to presume it worked without testing it |
hey @UzairNoman 👋 assigned the ticket to you, we will check your PR soon ;) thanks a lot! 🤝 |
Reproduction Steps
The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type". is printed in the console.
Expected Behaviour
The text was updated successfully, but these errors were encountered: