Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Elevate Profile Card Z-Index for Better Visibility #4268

Open
2 tasks done
shaikahmadnawaz opened this issue Oct 1, 2023 · 20 comments
Open
2 tasks done
Assignees
Labels

Comments

@shaikahmadnawaz
Copy link

📜 Description

Currently, when clicking on the profile, the profile card is not positioned correctly in terms of its z-index. As a result, it appears beneath other elements on the page, causing visibility issues.

👟 Reproduction steps

Click on the user's profile, triggering the profile card to open.

Observe the behavior of the profile card:

Note whether the profile card consistently appears on top of all other page elements.
Identify any instances where the profile card is obscured or partially hidden by other content on the page.

👍 Expected behavior

The profile card should immediately and smoothly appear on the screen without any delays or flickering.

The profile card should consistently and reliably appear on top of all other page elements, ensuring that it is fully visible and accessible to the user.

It should not be obscured, hidden, or partially covered by any other content, such as text, images, or buttons, on the page.

👎 Actual Behavior with Screenshots

Screenshot 2023-10-01 103110

Novu version

0.19.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@github-actions github-actions bot added the triage label Oct 1, 2023
@subharthihazra
Copy link

I can fix this, please assign me this issue.

@shaikahmadnawaz
Copy link
Author

shaikahmadnawaz commented Oct 1, 2023

Can I proceed @scopsy, Is this a valid issue?

@ainouzgali
Copy link
Contributor

Yes @shaikahmadnawaz , good find. Thank you!

@shaikahmadnawaz
Copy link
Author

image

This is the issue I am facing when I try to run it locally, can you please help me @ainouzgali.

@Shiva1406
Copy link
Contributor

I have made the required changes, kindly review and let me know if any alterations are required.

@shaikahmadnawaz
Copy link
Author

I have made the required changes, kindly review and let me know if any alterations are required.

This issue is assigned for me right? @Shiva1406

@Shiva1406
Copy link
Contributor

yes, @shaikahmadnawaz I was working on the issue parallely and thought I would send in my code. My apologies for being abrupt as it is my first time contributing to open source.

@shaikahmadnawaz
Copy link
Author

yes, @shaikahmadnawaz I was working on the issue parallely and thought I would send in my code. My apologies for being abrupt as it is my first time contributing to open source.

Are you able to run this code locally? @Shiva1406

@shaikahmadnawaz
Copy link
Author

shaikahmadnawaz commented Oct 1, 2023

image

This is the issue I am facing when I try to run it locally, can you please help me @ainouzgali.

@LetItRock, can you please help?

@LetItRock
Copy link
Contributor

image
This is the issue I am facing when I try to run it locally, can you please help me @ainouzgali.

@LetItRock, can you please help?

hey, please try to clone and run the project locally instead of doing this from the Codespaces.

@shaikahmadnawaz
Copy link
Author

image
This is the issue I am facing when I try to run it locally, can you please help me @ainouzgali.

@LetItRock, can you please help?

hey, please try to clone and run the project locally instead of doing this from the Codespaces.

I am facing the same issue locally also @LetItRock

Screenshot (1313)

@djabarovgeorge
Copy link
Contributor

@shaikahmadnawaz could you try to set up the project with npm run setup:project instead?

@shaikahmadnawaz
Copy link
Author

image

npm run setup:project @djabarovgeorge

@LetItRock
Copy link
Contributor

image

npm run setup:project @djabarovgeorge

@shaikahmadnawaz it looks like everything is built properly :) you can now run the apps manually or with Jarvis ;)

@shaikahmadnawaz
Copy link
Author

image

Check this once @LetItRock, mine is windows 11.

@michaldziuba03
Copy link
Contributor

@shaikahmadnawaz

to be honest, developing on Windows is painful. I would suggest to use WSL - this is what I personally do on my windows machine.

I also had heap out of memory error in the past. I will assume you have enough RAM memory in your machine.

Set env variable:

export NODE_OPTIONS='--max-old-space-size=8192'

For Linux and MacOS

$Env:NODE_OPTIONS='--max-old-space-size=8192'

For Windows (Powershell)

Keep in mind every time you open terminal, you will need to set NODE_OPTIONS env variable.

@shaikahmadnawaz
Copy link
Author

@shaikahmadnawaz

to be honest, developing on Windows is painful. I would suggest to use WSL - this is what I personally do on my windows machine.

I also had heap out of memory error in the past. I will assume you have enough RAM memory in your machine.

Set env variable:

export NODE_OPTIONS='--max-old-space-size=8192'

For Linux and MacOS

$Env:NODE_OPTIONS='--max-old-space-size=8192'

For Windows (Powershell)

Keep in mind every time you open terminal, you will need to set NODE_OPTIONS env variable.

Thank you so much for guiding @michaldziuba03

@shaikahmadnawaz
Copy link
Author

shaikahmadnawaz commented Oct 3, 2023

Now it's working fine locally, but I am facing this issue @michaldziuba03, the command I used to run it locally is npm run start:web

image

@michaldziuba03
Copy link
Contributor

@shaikahmadnawaz

do you have API running?

You need at least API and WEB app

npm run start:web
npm run start:api

API requires running both MongoDB and Redis.

@shaikahmadnawaz
Copy link
Author

@shaikahmadnawaz

do you have API running?

You need at least API and WEB app

npm run start:web
npm run start:api

API requires running both MongoDB and Redis.

Okay, Thank you @michaldziuba03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants