Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2825] Templates Store should have Blank Workflow in the List so users do not have to pop out to reselect it #4258

Closed
LetItRock opened this issue Sep 30, 2023 · 13 comments · Fixed by #4323
Assignees
Labels

Comments

@LetItRock
Copy link
Contributor

LetItRock commented Sep 30, 2023

What?

Currently, the blank workflow is not listed in the template store.

Screen.Recording.2023-09-30.at.23.35.31.mov

Why? (Context)

Because the blank workflow is not listed, a user has to restart the full process to select a blank workflow.

Definition of Done

  • The user should be able to select a blank workflow from the Template Store
@rohitkbc
Copy link
Contributor

Hi @LetItRock 👋, Can you assign this task to me?

@LetItRock
Copy link
Contributor Author

Hi @LetItRock 👋, Can you assign this task to me?

yes, good luck! 🤞

@Chandan-Singh10
Copy link

Hey, can you assign me this issue? I am willing to work on this.

@RajAditya01
Copy link

Hello, I'd like to express my interest in taking on this issue. Please consider assigning it to me as I'm eager to work on it

@rohitkbc
Copy link
Contributor

rohitkbc commented Oct 1, 2023

Hi @LetItRock, I have setup environment locally but while running project locally after clicking on Add a workflow, dropdown list is not appearing, instead it is going towards untitled workflow.

image

@LetItRock
Copy link
Contributor Author

hey @rohitkbc! 👋 yes, sorry for not mentioning that, we are using the feature flag mechanism, you have to return the temporarily the "true" value from the useIsTemplateStoreEnabled hook defined in the apps/web/src/hooks/useFeatureFlags.ts file ;) but please do not commit that change ;)

@LetItRock
Copy link
Contributor Author

hey @Chandan-Singh10 @RajAditya01! 👋
thanks for your willingness to contribute :) please take a look into some other tickets that are not taken, we have many more ;)

@capGoblin
Copy link

hey hi, i made the necessary changes kindly review.

@rohitkbc
Copy link
Contributor

rohitkbc commented Oct 2, 2023

Hi @capGoblin, this task is assigned to me and I am working on it.

@LetItRock
Copy link
Contributor Author

Hi @capGoblin, this task is assigned to me and I am working on it.

hey @rohitkbc 👋 we are looking forward for the PR from you ;)

@rohitkbc
Copy link
Contributor

rohitkbc commented Oct 3, 2023

Hey @LetItRock 👋, I have made necessary changes. Please review it. 😊

@LetItRock
Copy link
Contributor Author

Hey @LetItRock 👋, I have made necessary changes. Please review it. 😊

thanks @rohitkbc! you rock! 🚀 we will review it soon ;)

@rohitkbc
Copy link
Contributor

@LetItRock hey 👋, Its been long time. Can you please review 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants