[NV-2657] Add icons to the alerts component

[LetItRock]

What?

Update the Workflow Settings component with the error and warning icons.

Why?

Improve the UX of this component.

Definition of done

• Add the warning and error icons according to the designs
• show the yellow warning banner only for the SMS or Email channels if there is only one Novu SMS/Email integration

[rayy40]

Hey, can you assign me this issue? I am willing to work on this.

[LetItRock]

Hey, can you assign me this issue? I am willing to work on this.

sure, you are assigned! 🤝

[Mrityunjay1]

is this done

[rayy40]

@Mrityunjay1 I am working on it.

[Chandan-Singh10]

Hey, can you assign me this issue? I am willing to work on this.

[Ashutosh0602]

Hey @LetItRock I tried to fix the issue and made a PR request you can check and verify it.

[LetItRock]

hey @Mrityunjay1 @Chandan-Singh10! 👋
friends, please take a look into some other tickets we have ;)

[SahilAli8808]

@rayy40 is it done? if not then can you assign it to me

[LetItRock]

@rayy40 we are looking forward to the PR from you ;)

[sohan01fw]

@LetItRock Iam new to this contribution thing how should I know which issue is already done fixing or which one is not cause everyone is working on it and I don't have an idea of what should I pick first from good first issue.

[LetItRock]

@LetItRock Iam new to this contribution thing how should I know which issue is already done fixing or which one is not cause everyone is working on it and I don't have an idea of what should I pick first from good first issue.

hey @sohan01fw! there is only one person assigned to the ticket, you can see that under the Assignees ;) the rules are described here: #4315

I would suggest you also read a few contribution guidelines on the internet and learn how GitHub works ;) for example these two: https://opensource.guide/how-to-contribute/, https://digital.gov/resources/an-introduction-github/

[rayy40]

@LetItRock hey, I was having trouble setting it up locally, so I asked in the discord and someone said that they are working on this #4318 and it will be updated soon, so I am unable to set it up till it's fixed.
Checked the discord now, they fixed it so I'd start working on it.

[rayy40]

@rayy40 is it done? if not then can you assign it to me

Will try doing it today, if faced with any problems will let you know.

[rayy40]

@LetItRock The workflow setting component already has a MissingIcon, so I was wondering whether I should replace that with error and warning icon depending on the alertType.

And one more thing, should I create two different components each for Warning Icon and Error Icon, or should I just use one component with conditional rendering based on the alertType.

[LetItRock]

@LetItRock The workflow setting component already has a MissingIcon, so I was wondering whether I should replace that with error and warning icon depending on the alertType.

yes, please replace that icon with an error icon

And one more thing, should I create two different components each for Warning Icon and Error Icon, or should I just use one component with conditional rendering based on the alertType.

good question, I think it's better to use the conditional rendering ;)

---

one additional ask, could you please show that yellow warning banner for the SMS or Email channels if there is only Novu SMS/Email integration? I'll update it in the description too ;) thanks a lot! 🙌

[rayy40]

one additional ask, could you please show that yellow warning banner for the SMS or Email channels if there is only Novu SMS/Email integration? I'll update it in the description too ;) thanks a lot! 🙌

Yeah sure thing, I'll update that.

[rayy40]

Hey @LetItRock I submitted a PR with the changes, please take a look at it and let me know if any changes are required.

[MohdHasan2502]

Can You Assign me this task?

[Akash-9794]

Hey, can you assign me this issue? I am excited to work on this.

[muzzammilHub]

hey, can you assign me this issue? I am willing to work on this....