Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2031] 🏗️ [WF editor] Update icon and hint for Fit to screen control #4252

Closed
LetItRock opened this issue Sep 30, 2023 · 13 comments
Closed

Comments

@LetItRock
Copy link
Contributor

What?

The fit-to-screen function has the wrong icon.

Why?

The current icon refers to the full-screen button instead. So it's not working as expected. It's confusing and influences the product's credibility.

Definition of done

  • The Fit-to-screen control has an updated icon
  • On hover over an icon UI displays a background under all the buttons (+,–,fit)
  • On hover over an icon UI display a hint

Designs:
The zoom-in/zoom-out/fit to screen
The zoom-in/zoom-out/fit to screen

@JanetEne
Copy link

JanetEne commented Oct 1, 2023

@LetItRock , i would like to work on this. can you assign this to me?

@AkshitSinghal224
Copy link

hii i love to work on this one can please assign it to me

@parag477
Copy link

parag477 commented Oct 1, 2023

Hey I want to work on this can you please assign this issue to me?

@3xp10it3r
Copy link

Hi @LetItRock
Hope you are doing good,
I have started working on this, Please assign this to me.

@SPARSH1608
Copy link

@LetItRock Please assign this issue to me under @Hacktoberfest'23

@LetItRock
Copy link
Contributor Author

@LetItRock , i would like to work on this. can you assign this to me?

yes, sure :) thanks! 🙌

@LetItRock
Copy link
Contributor Author

hey friends 👋 @TheNatkat @parag477 @3xp10it3r @SPARSH1608
thanks for your willingness to help 🤝 we have many more tickets, please take a look at some others that are not assigned or you can also contribute to the project without the ticket, for example, improve typescript types, or extract the code to components, move something to hooks, add tests ;) we would really appreciate your help :)

@Vishalk91-4
Copy link

@LetItRock , could you please assign this issue to me if it's inactive

@AkshitSinghal224
Copy link

i also love to work on this one

@JanetEne
Copy link

@Vishalk91-4 , @TheNatkat it isn't inactive as I am wrapping up working on it.

@AkshitSinghal224
Copy link

@JanetEne Ok if you need any help just let me know

mr-unmole pushed a commit to mr-unmole/novu that referenced this issue Oct 31, 2023
@mr-unmole
Copy link

@LetItRock Please review my pull request & if it is correct please merge it.

@scopsy
Copy link
Contributor

scopsy commented Nov 6, 2023

@anmol-matharu-100 Currently @JanetEne is working on the issue 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants