[NV-2040] 👁️ [Visual fix] Fix cut shadow

[LetItRock]

What?

On the Get Started page in the second step, the shadow is cut at the bottom of the Email node.

Why?

Visually it doesn't look good :)

Definition of done

• make the react flow container height or min-height a little bigger
• on the 1280x720 there should be no scrollbar

[vibh1103]

Hi @LetItRock can i pick this task ?

[LetItRock]

Hi @LetItRock can i pick this task ?

of course, assigned it to you 🤝

[jatinder14]

@LetItRock only the email shadow should be removed or the digest and trigger button should also be removed ?

[LetItRock]

@LetItRock only the email shadow should be removed or the digest and trigger button should also be removed ?

hey @jatinder14 👋 We didn't want to remove the shadow, but rather increase the container height so it will be better visible. Btw the ticket is already assigned to another person ;) but if you would like to contribute, please take a look into some other not assigned tickets ;)

[jatinder14]

hi @LetItRock @vibh1103 sorry for the inconvenience but I started working on this task when no one was assigned to it.
if you guys don't mind then I have solved this task ,
may I make a Pull Request for it?

[vibh1103]

Ok @jatinder14 you can work on it then
@LetItRock is there any other task I can pick please assign it to me

[jatinder14]

@LetItRock the react flow container is already having 100% height .
could you advise me some solution please ?

[Rajaa786]

Is the issue solved? If not, do assign it to me?

[PankajKumarAgrawal1729]

Hi @LetItRock,
Can you please assign this for me?

[LetItRock]

hey @Rajaa786 @PankajKumarAgrawal1729 👋
Is anyone available to take a look here?

[anirudhp26]

Hey, Is this issue still relevant?

[LetItRock]

Hey, Is this issue still relevant?

yes, it is :) @anirudhp26 do you want to give it a try?

[ebraj]

Hi @LetItRock sir, I wanna give it a try can you assign me please 🤗, but before that I wanna confirm myself if I actually understood the issue or not.

These are the tasks right? (As per the issue & the comments on the PRs created for this issue)

1. To fix the alignment of the React Flow tag whatever be the screen sizes.
2. Fixing the shadow being little below on the Email Node by following the instruction as per the Definition of done on issue

If I am wrong, can you correct me an assign it to me 🤗

[anirudhp26]

@LetItRock , Please assign it to @ebraj, he has a better understanding of this issue tbh, I'll look for another one

[LetItRock]

Hi @LetItRock sir, I wanna give it a try can you assign me please 🤗, but before that I wanna confirm myself if I actually understood the issue or not.

These are the tasks right? (As per the issue & the comments on the PRs created for this issue)

1. To fix the alignment of the React Flow tag whatever be the screen sizes.
2. Fixing the shadow being little below on the Email Node by following the instruction as per the Definition of done on issue

If I am wrong, can you correct me an assign it to me 🤗

yes, that's correct! :) assigning it to you @ebraj :)

[ebraj]

Hi @LetItRock sir,

Updates :

• I fix the Flow alignment part(center alignment for screens) , but regarding the Shadow cut portion, I didn't notice anything, I tried giving the darker border to see if there is anything like shadow cut, please check this screenshot please.

Can you please, tell me where I went wrong @LetItRock sir?

[LetItRock]

Hi @LetItRock sir,

Updates :

• I fix the Flow alignment part(center alignment for screens) , but regarding the Shadow cut portion, I didn't notice anything, I tried giving the darker border to see if there is anything like shadow cut, please check this screenshot please.

Can you please, tell me where I went wrong @LetItRock sir?

can you please create a PR and I'll take a look? 🙏

[ebraj]

Sure @LetItRock sir, creating a PR 🤗

[ebraj]

Hi @LetItRock sir, here is the PR - #4591 . Please have a look sir, I worked on the alignment part, will work on the shadow cut as per you suggestion 🙏

[ebraj]

Hi @LetItRock sir, did you have a look at my PR?