Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2929] [NV-2756] When switching the organization the branding information is not refetched #4232

Closed
LetItRock opened this issue Sep 29, 2023 · 13 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@LetItRock
Copy link
Contributor

LetItRock commented Sep 29, 2023

Reproduction Steps

  1. Navigate to the Brand page, make sure you have logo or font changed from defaults and saved.
  2. Change the organization.
  3. The branding settings are not updated.
Screen.Recording.2023-08-25.at.13.08.06.1.mov

Definition of done

  • The branding reflects currently selected organisation.
  • Display branding related to the selected organisation.

From SyncLinear.com | NV-2756

NV-2929

@LetItRock LetItRock changed the title [NV-2756] When switching the organization the branding information is not refetched [NV-2929] [NV-2756] When switching the organization the branding information is not refetched Sep 29, 2023
@shakthi2003-ice
Copy link

Hey
The video is not displayed properly

@SarmadKhoja95
Copy link
Contributor

@LetItRock not able to view/play video.

@LetItRock LetItRock added good first issue Good for newcomers Hacktoberfest bug Something isn't working labels Oct 3, 2023
@LetItRock
Copy link
Contributor Author

@LetItRock not able to view/play video.

@SarmadKhoja95 @shakthi2003-ice thanks, I've just re-uploaded the video ;)

@SarmadKhoja95
Copy link
Contributor

@LetItRock Can you assign this to me i would like to work on this one?

@LakshayGMZ
Copy link

LakshayGMZ commented Oct 3, 2023

Please assign me the issue @LetItRock ,
Thanks!

@nick2432
Copy link
Contributor

nick2432 commented Oct 3, 2023

can i work on this?

@ASCE-D
Copy link

ASCE-D commented Oct 3, 2023

Hey Devs I would like to contribute can you please assign me this issue

@Anonymous961
Copy link

@LetItRock, I've checked the SideNav.tsx, where I found the OrganisationSelect component. Whenever an organisation is selected, the data according to that organisation should be updated. I believe there could be a simple fix by using AuthContext in the BrandingForm page and re-rendering the page every time the organization is changed. Please assign me this issue so that I can work on it with a better approach.

@07tAnYa
Copy link

07tAnYa commented Oct 4, 2023

Hey! can you assign this to me, I can fix this issue.

@davidsoderberg
Copy link
Contributor

@SarmadKhoja95 I have now assigned this to you :)

@SarmadKhoja95
Copy link
Contributor

@davidsoderberg I think its a duplicate of #4297 which is already merged.

@SarmadKhoja95
Copy link
Contributor

You can close this one so I can work on another one. Thanks !

@davidsoderberg
Copy link
Contributor

Yes seems like thanks for finding that out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants