Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NV-2128] Add unmask button for API keys #4231

Closed
jainpawan21 opened this issue Sep 29, 2023 · 6 comments · Fixed by #4265
Closed

[NV-2128] Add unmask button for API keys #4231

jainpawan21 opened this issue Sep 29, 2023 · 6 comments · Fixed by #4265
Assignees
@pedrobruneli
Labels
Design ready for dev Created by Linear-GitHub Sync Feature Created by Linear-GitHub Sync Hacktoberfest Low priority Created by Linear-GitHub Sync
Milestone
Cycle 29

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented Sep 29, 2023 •
edited
Loading

What?

Implement an unmask button for the API key field..

Why?

The user has the option to copy the API key and application identifier. Sometimes in the case of self-hosting, the browser blocks the copy action on http.

Definition of done

  • the unmask button is added to the API key field on the left to the copy button
  • when the unmask button is clicked the API key value is shown to the user

Worflows / New workflow - Crafting updates (Figma)

Worflows / New workflow - Crafting updates (Figma)

From SyncLinear.com | NV-2128
@jainpawan21 jainpawan21 added Design ready for dev Created by Linear-GitHub Sync Feature Created by Linear-GitHub Sync Hacktoberfest Low priority Created by Linear-GitHub Sync labels Sep 29, 2023
@jainpawan21
Copy link
Member Author

Thanks Nikolay

@jainpawan21
Copy link
Member Author

@jainpawan21 Please verify design, added in the task

@jainpawan21
Copy link
Member Author

Checkout this loom video @nikolay

https://www.loom.com/share/156f9c146bc244d8bc4a8e41a4492a30

@jainpawan21
Copy link
Member Author

@jainpawan21 Hey Pawan 👋 could you please elaborate more on that task, not clear what is about, thanks

@pedrobruneli
Copy link
Contributor

Can i contrib to this one?

@Sranjan0208
Copy link

Can I work on this issue?

@panugothrakesh panugothrakesh mentioned this issue Sep 30, 2023
Closed
@pedrobruneli pedrobruneli mentioned this issue Oct 1, 2023
Merged
@jainpawan21 jainpawan21 added this to the Cycle 29 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedrobruneli pedrobruneli

Labels
Design ready for dev Created by Linear-GitHub Sync Feature Created by Linear-GitHub Sync Hacktoberfest Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
Cycle 29
3 participants
@jainpawan21 @Sranjan0208 @pedrobruneli