Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Switch style messed up when adding a long description #4198

Closed
2 tasks done
firassziedan opened this issue Sep 25, 2023 · 7 comments · Fixed by #5044
Closed
2 tasks done

🐛 Bug Report: Switch style messed up when adding a long description #4198

firassziedan opened this issue Sep 25, 2023 · 7 comments · Fixed by #5044
Assignees

Comments

@firassziedan
Copy link
Contributor

📜 Description

On the integrations page, within the integration popup, when a switch component is present as part of an integration option, and that switch component includes a lengthy description, there is a formatting issue where the description and the input element are not properly aligned.

👟 Reproduction steps

1- Edit/Create integration and that integration has a switch component and add a description to that component
2- open integrations pages
3- open the integration dialog

👍 Expected behavior

I believe it would be more visually appealing if the description were placed on a new line, separate from the input wrapper.

👎 Actual Behavior with Screenshots

Screenshot 2023-09-24 at 11 07 00

Novu version

next

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@gitstart
Copy link
Contributor

@firassziedan we would like to pick this up cc @scopsy @jainpawan21

@scopsy
Copy link
Contributor

scopsy commented Sep 26, 2023

@gitstart I would love to close first the open PR's and merge them before we will assign more issues 🙏

@cdxgh
Copy link

cdxgh commented Oct 2, 2023

@LetItRock, @scopsy I would like to work on this issue.

@jainpawan21
Copy link
Member

@cdxgh how is it going with this issue?

@scopsy scopsy unassigned cdxgh Nov 6, 2023
@scopsy
Copy link
Contributor

scopsy commented Nov 6, 2023

@nknyshov could you please take a look at this, and perhaps provide a design alternative in case you think it will be better?

@jainpawan21
Copy link
Member

@firassziedan

Since we have updated integrations UI, could you please share the steps to reproduce?
I could not reproduce this

@firassziedan
Copy link
Contributor Author

@jainpawan21 you can see it by open Generic SMS provider and scrolling to Authenticate by token field

Screenshot 2023-12-21 at 17 26 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants