Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: missing methods in Node SDK #4164

Closed
2 tasks done
sumitsaurabh927 opened this issue Sep 18, 2023 · 6 comments · Fixed by #4746
Closed
2 tasks done

🚀 Feature: missing methods in Node SDK #4164

sumitsaurabh927 opened this issue Sep 18, 2023 · 6 comments · Fixed by #4746
Assignees
@peoray
Labels
enhancement New feature or request Hacktoberfest

Comments

@sumitsaurabh927
Copy link
Contributor

🔖 Feature description

Two methods are missing in the Node SDK:

  • execution details: /v1/execution-details
  • inbound parse: /v1/inbound-parse/mx/status

Please add these to the SDK

🎤 Why is this feature needed ?

To bring the SDK on par with the API endpoint methods available

✌️ How do you aim to achieve this?

Tagging @jainpawan21 to work on this issue, as requested by Prosper.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None
@sumitsaurabh927 sumitsaurabh927 added the enhancement New feature or request label Sep 18, 2023
@peoray
Copy link
Contributor

peoray commented Sep 18, 2023

can I pick this up?

@sumitsaurabh927
Copy link
Contributor Author

sumitsaurabh927 commented Sep 18, 2023 •
edited
Loading

Sure, go ahead @peoray. I've assigned you to this issue @peoray

@sumitsaurabh927
Copy link
Contributor Author

Any update on this @peoray ?

@peoray
Copy link
Contributor

peoray commented Oct 4, 2023

@sumitsaurabh927 will send in a PR asap

@jainpawan21
Copy link
Member

Hi @peoray
Are you still working on this?

@peoray
Copy link
Contributor

peoray commented Oct 25, 2023

@jainpawan21 yeah, already started working on it but slacked a bit. will get a PR up

@peoray peoray mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peoray peoray

Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add execution-details and inbound-parse to node sdk peoray/novu
3 participants
@peoray @jainpawan21 @sumitsaurabh927