[NV-2195] 🐛 Bug Report: Visual bug in Add filter button icon

[michaldziuba03]

📜 Description

It's small visual bug. Icon doesn't change color on theme change.

👟 Reproduction steps

1. Navigate to template editor
   

2. Set theme to light
   

👍 Expected behavior

Icon should change color to keep contrast after theme change.

👎 Actual Behavior with Screenshots

Look at Add filter button:

As we can see - the icon doesn't change color when changing the theme.

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to submit PR?

Yes I am willing to submit a PR!

_NV-2195

[himanshu1221]

Can I work on this issue?

[scopsy]

Sure @himanshu1221, assigning you 🚀

[himanshu1221]

hey @scopsy can you guide me on how I can setup this up in gitpod

[scopsy]

Haven't used GitPod in a while now :( But you will only need to run the @novu/api and @novu/web projects to see this.

[gitstart]

@scopsy is this issue still available for pickup?

[himanshu1221]

@scopsy is this issue still available for pickup?

I am working on it @gitstart

[gitstart]

@scopsy is this issue still available for pickup?

I am working on it @gitstart

Alright

[gitstart]

Are you still working on this? @himanshu1221

[jainpawan21]

@himanshu1221 unassigned you from the issue
Waiting for someone else to pick up

[gitstart]

@jainpawan21 we would like to work on this.

[harshhere905]

hey can i take the issue. I would like to work on it

[snehpr966]

Would like to fix it

[victoriatrinita]

I would like to work on this issue

[vishalkhoje]

Kindly assign this issue to my name. I am presently engaged in addressing a related matter, as it pertains not only to a filter but also involves various other issues concerning light theme icons. I am committed to rectifying all of these issues comprehensively.

[vishalkhoje]

Hello @michaldziuba03 @jainpawan21

Link to PR: #4356

I've included screenshots and a video to provide additional context and details regarding the fix for this visual bug. Please take a look.

Thank you! 🙏🏼

[ASCE-D]

Hey Devs I would like to contribute can you please assign me this issue

[sidonweb]

Hello! I'd like to contribute to this issue. Can you assign me this?

[davidsoderberg]

Hi @harshhere905 are you ready to work on this one?

[vishalkhoje]

Hi @davidsoderberg ,
If possible can you able to consider or please check my PR: #4356
I raised it PR yesterday.
Thank you!

[harshhere905]

yes @davidsoderberg please assign me this task

[davidsoderberg]

@harshhere905 you are now assigned to this task :)

[harshhere905]

@davidsoderberg please unassign me this task

[vishalkhoje]

Please assign me @davidsoderberg
I have already raised the PR for this few days ago.
I am also working on another issue that will also, I will try to finish today.
Thanks

[davidsoderberg]

@snehpr966 are you ready to work on this?