-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NV-1522] ποΈ Rename organisation #2402
Comments
@scopsy this looks like a quick win. I can work on it However, @jainpawan21 can provide more description. Thanks |
Unfortuently we don't have a UI for this functionality yet π¦ |
sounds good. |
@Abobos |
@jainpawan21 noted. @scopsy do we have to create a separate ticket for this? |
No, No need you can create PR and reference this issue only. |
@jainpawan21 @scopsy I have started working on the API endpoint here. I am thinking since branding is part of the organization resource.. why not move the updating of branding to the same endpoint.. so to speak, we will just have one endpoint that does organization update |
@scopsy your thoughts? |
I would prefer to leave the branding separate at this moment, since in the future they might evolve for different directions and needs. Even if they feel quite similar right now. |
@scopsy is this feature closed? |
@scopsy we need to implement this on the web application, I mean the admin panel.. right? |
Yes @Abobos but unfortuently we don't yet have a design for this part of work. We need to think how to incorporate this as a organization details page or something like this. |
@scopsy yes.. However, @nknyshov can give his thoughts about the design |
@Abobos Thanks for the proposal, this is something I wanted to fix either. But I have doubts about the place you suggesting. I think that the functionality of changing a name as well as the deletion of the organisation should be in place, right in the dropdown. Not sure that decision to keep that functionality in settings will be discoverable. What do you think? |
which dropdown are you referring to? |
|
@Abobos Hi, I refer to the dropdown that allows you to switch between companies |
@nknyshov The dropdown just shows the list of organisations.. so to speak, it is an organisation switcher.. I am a bit torn on how we can accommodate for the delete/rename organization functionality here.. if you already have a design on this for me to get a visual perspective, you can share π |
@Abobos Hey, sorry for the delayed reply. I lost the notification about your reply in my inbox, so I didn't see your question, sorry. I haven't prepared the design yet, I plan to work on it within the upcoming month or two. As far as I get the design, I will come back to you and we could discuss the details. Does it sound like a plan to you? Please let me know if you have any additional questions. |
Noted @nknyshov |
I have a request regarding this feature, could it be possible to add the corresponding methods in the novu client package and in the api docs? See #1315 |
@nknyshov Do you have the design now? |
@florian-lefebvre noted.. I can work on it. Is there a ticket to add this particular API endpoint? Also, This should be under organisation module. We don't have a module for organisation yet in @novu/node package. Maybe we should create a ticket for adding the organisation module in this case. cc: @scopsy |
Sounds good to me π |
@nknyshov @trueadic waiting for the designs |
@scopsy can we create a ticket for this?.. or I should just work on it without linking any ticket/issue? |
@nknyshov @trueadic any update on the design.. I am leaning towards raising a PR with the design I propose. cc: @scopsy @jainpawan21 |
@Abobos Hey π Thanks for staying tuned, we remember about the issue and plan to roll up updates in Q4. |
Okay. I will pick another issue to work on before then... keep me in the loop @nknyshov |
@Abobos I will let you know as soon as we finalize the design, thank you! |
@nknyshov Is the design now finalized? |
Yes @Abobos but unfortuently it's going to be part of a very big project for redesigning the navigation stack. I will close this ticket at the moment. |
@scopsy the design is ready right?.. Where can I access this design so I can start work on it |
π Feature description
Adding support of renaming organisation
π€ Why is this feature needed ?
it is not possible to either delete or rename organisation. only option is to create new organisation
βοΈ How do you aim to achieve this?
Implementing API first and then in Web
ποΈ Additional Information
No response
π Have you spent some time to check if this feature request has been raised before?
π’ Have you read the Code of Conduct?
Are you willing to submit PR?
None
Solution
Development / Workflows - Crafting updates (Figma)
Admin / Project profile - Crafting updates (Figma)
From SyncLinear.com | NV-1522
The text was updated successfully, but these errors were encountered: