Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-1522] πŸ›οΈ Rename organisation #2402

Closed
2 tasks done
jainpawan21 opened this issue Jan 2, 2023 · 35 comments
Closed
2 tasks done

[NV-1522] πŸ›οΈ Rename organisation #2402

jainpawan21 opened this issue Jan 2, 2023 · 35 comments
Labels
Design ready for dev Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync linear polishing Created by Linear-GitHub Sync
Milestone

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented Jan 2, 2023

πŸ”– Feature description

Adding support of renaming organisation

🎀 Why is this feature needed ?

it is not possible to either delete or rename organisation. only option is to create new organisation

✌️ How do you aim to achieve this?

Implementing API first and then in Web

πŸ”„οΈ Additional Information

No response

πŸ‘€ Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Solution

Development / Workflows - Crafting updates (Figma)

Admin / Project profile - Crafting updates (Figma)

From SyncLinear.com | NV-1522

@Abobos
Copy link
Contributor

Abobos commented Jan 15, 2023

@scopsy this looks like a quick win. I can work on it However, @jainpawan21 can provide more description. Thanks

@scopsy scopsy added linear and removed linear labels Jan 18, 2023
@scopsy scopsy changed the title πŸš€ Feature: rename organisation [NV-1522] πŸš€ Feature: rename organisation Jan 18, 2023
@scopsy
Copy link
Contributor

scopsy commented Jan 18, 2023

Unfortuently we don't have a UI for this functionality yet 😦
But maybe you want to create an API endpoint for updating organizations?

@scopsy scopsy added the Missing Designs Created by Linear-GitHub Sync label Jan 18, 2023
@Abobos
Copy link
Contributor

Abobos commented Jan 18, 2023

Unfortuently we don't have a UI for this functionality yet 😦

But maybe you want to create an API endpoint for updating organizations?

sounds good.

@jainpawan21
Copy link
Member Author

@Abobos
Copy link
Contributor

Abobos commented Jan 19, 2023

@jainpawan21 ,

@Abobos You can add this new endpoint here https://github.com/novuhq/novu/blob/next/apps/api/src/app/organization/organization.controller.ts

@jainpawan21 noted. @scopsy do we have to create a separate ticket for this?

@jainpawan21
Copy link
Member Author

No, No need you can create PR and reference this issue only.

@Abobos
Copy link
Contributor

Abobos commented Jan 28, 2023

@jainpawan21 @scopsy I have started working on the API endpoint here. I am thinking since branding is part of the organization resource.. why not move the updating of branding to the same endpoint.. so to speak, we will just have one endpoint that does organization update

@jainpawan21
Copy link
Member Author

@jainpawan21 @scopsy I have started working on the API endpoint here. I am thinking since branding is part of the organization resource.. why not move the updating of branding to the same endpoint.. so to speak, we will just have one endpoint that does organization update

@scopsy your thoughts?

@scopsy
Copy link
Contributor

scopsy commented Jan 29, 2023

I would prefer to leave the branding separate at this moment, since in the future they might evolve for different directions and needs. Even if they feel quite similar right now.

@scopsy scopsy added polishing season Created by Linear-GitHub Sync polishing Created by Linear-GitHub Sync and removed polishing season Created by Linear-GitHub Sync labels Jan 30, 2023
@abhisheksunil2201
Copy link

@scopsy is this feature closed?

@Abobos
Copy link
Contributor

Abobos commented Feb 11, 2023

@scopsy we need to implement this on the web application, I mean the admin panel.. right?

@scopsy
Copy link
Contributor

scopsy commented Feb 12, 2023

Yes @Abobos but unfortuently we don't yet have a design for this part of work. We need to think how to incorporate this as a organization details page or something like this.

@Abobos
Copy link
Contributor

Abobos commented Apr 1, 2023

Yes @Abobos but unfortuently we don't yet have a design for this part of work. We need to think how to incorporate this as a organization details page or something like this.

@scopsy I think we can incorporate this in the settings page. kindly see the screenshot below. Let me know what you think.

Screenshot 2023-04-01 at 21 53 44

@scopsy
Copy link
Contributor

scopsy commented Apr 2, 2023

@Abobos this could actually work for now, @nknyshov what do you think?

@Abobos do you want to submit a PR?

@Abobos
Copy link
Contributor

Abobos commented Apr 2, 2023

@scopsy yes.. However, @nknyshov can give his thoughts about the design

@trueadic
Copy link

trueadic commented Apr 4, 2023

@Abobos Thanks for the proposal, this is something I wanted to fix either. But I have doubts about the place you suggesting. I think that the functionality of changing a name as well as the deletion of the organisation should be in place, right in the dropdown. Not sure that decision to keep that functionality in settings will be discoverable. What do you think?

@Abobos
Copy link
Contributor

Abobos commented Apr 7, 2023

@Abobos Thanks for the proposal, this is something I wanted to fix either. But I have doubts about the place you suggesting. I think that the functionality of changing a name as well as the deletion of the organisation should be in place, right in the dropdown. Not sure that decision to keep that functionality in settings will be discoverable. What do you think?

which dropdown are you referring to?

@Abobos
Copy link
Contributor

Abobos commented Apr 12, 2023

@Abobos Thanks for the proposal, this is something I wanted to fix either. But I have doubts about the place you suggesting. I think that the functionality of changing a name as well as the deletion of the organisation should be in place, right in the dropdown. Not sure that decision to keep that functionality in settings will be discoverable. What do you think?

which dropdown are you referring to?

@trueadic

@ghost
Copy link

ghost commented Apr 13, 2023

@Abobos Hi, I refer to the dropdown that allows you to switch between companies
Screenshot 2023-04-13 at 11 15 36

@Abobos
Copy link
Contributor

Abobos commented Apr 14, 2023

@Abobos Hi, I refer to the dropdown that allows you to switch between companies Screenshot 2023-04-13 at 11 15 36

@nknyshov The dropdown just shows the list of organisations.. so to speak, it is an organisation switcher.. I am a bit torn on how we can accommodate for the delete/rename organization functionality here.. if you already have a design on this for me to get a visual perspective, you can share πŸ˜„

@ghost
Copy link

ghost commented May 1, 2023

@Abobos Hey, sorry for the delayed reply. I lost the notification about your reply in my inbox, so I didn't see your question, sorry. I haven't prepared the design yet, I plan to work on it within the upcoming month or two. As far as I get the design, I will come back to you and we could discuss the details. Does it sound like a plan to you? Please let me know if you have any additional questions.

@Abobos
Copy link
Contributor

Abobos commented May 1, 2023

@Abobos Hey, sorry for the delayed reply. I lost the notification about your reply in my inbox, so I didn't see your question, sorry. I haven't prepared the design yet, I plan to work on it within the upcoming month or two. As far as I get the design, I will come back to you and we could discuss the details. Does it sound like a plan to you? Please let me know if you have any additional questions.

Noted @nknyshov

@florian-lefebvre
Copy link
Contributor

I have a request regarding this feature, could it be possible to add the corresponding methods in the novu client package and in the api docs? See #1315

@Abobos
Copy link
Contributor

Abobos commented May 31, 2023

@nknyshov Do you have the design now?

@Abobos
Copy link
Contributor

Abobos commented May 31, 2023

I have a request regarding this feature, could it be possible to add the corresponding methods in the novu client package and in the api docs? See #1315

@florian-lefebvre noted.. I can work on it. Is there a ticket to add this particular API endpoint? Also, This should be under organisation module. We don't have a module for organisation yet in @novu/node package. Maybe we should create a ticket for adding the organisation module in this case.

cc: @scopsy

@florian-lefebvre
Copy link
Contributor

Sounds good to me πŸ‘

@Abobos
Copy link
Contributor

Abobos commented Jun 30, 2023

@nknyshov @trueadic waiting for the designs

@Abobos
Copy link
Contributor

Abobos commented Jun 30, 2023

I have a request regarding this feature, could it be possible to add the corresponding methods in the novu client package and in the api docs? See #1315

@florian-lefebvre noted.. I can work on it. Is there a ticket to add this particular API endpoint? Also, This should be under organisation module. We don't have a module for organisation yet in @novu/node package. Maybe we should create a ticket for adding the organisation module in this case.

cc: @scopsy

@scopsy can we create a ticket for this?.. or I should just work on it without linking any ticket/issue?

@Abobos
Copy link
Contributor

Abobos commented Jul 27, 2023

@nknyshov @trueadic any update on the design.. I am leaning towards raising a PR with the design I propose.

cc: @scopsy @jainpawan21

@ghost
Copy link

ghost commented Aug 13, 2023

@Abobos Hey πŸ‘‹ Thanks for staying tuned, we remember about the issue and plan to roll up updates in Q4.

@Abobos
Copy link
Contributor

Abobos commented Aug 13, 2023

@Abobos Hey πŸ‘‹ Thanks for staying tuned, we remember about the issue and plan to roll up updates in Q4.

Okay. I will pick another issue to work on before then... keep me in the loop @nknyshov

@ghost
Copy link

ghost commented Aug 13, 2023

@Abobos I will let you know as soon as we finalize the design, thank you!

@Abobos
Copy link
Contributor

Abobos commented Nov 25, 2023

@Abobos I will let you know as soon as we finalize the design, thank you!

@nknyshov Is the design now finalized?

@scopsy
Copy link
Contributor

scopsy commented Nov 26, 2023

Yes @Abobos but unfortuently it's going to be part of a very big project for redesigning the navigation stack. I will close this ticket at the moment.

@scopsy scopsy closed this as completed Nov 26, 2023
@scopsy scopsy added the High priority Created by Linear-GitHub Sync label Dec 5, 2023
@scopsy scopsy reopened this Dec 5, 2023
@scopsy scopsy changed the title [NV-1522] πŸš€ Feature: rename organisation [NV-1522] πŸ›οΈ Rename organisation Dec 5, 2023
@scopsy scopsy added Design ready for dev Created by Linear-GitHub Sync and removed Missing Designs Created by Linear-GitHub Sync labels Dec 26, 2023
@scopsy scopsy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
@scopsy scopsy reopened this Jan 29, 2024
@scopsy scopsy added this to the Cycle 38 milestone Jan 29, 2024
@Abobos
Copy link
Contributor

Abobos commented Mar 18, 2024

@scopsy the design is ready right?.. Where can I access this design so I can start work on it

@scopsy scopsy closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design ready for dev Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync linear polishing Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

6 participants