From 506679c80c677bea3e618f5600b27e4e5190354b Mon Sep 17 00:00:00 2001
From: Dima Grossman <dima@grossman.io>
Date: Tue, 10 Dec 2024 00:34:18 +0200
Subject: [PATCH] fix: integration

---
 .../test-workflow-logs-sidebar.tsx            | 10 +++++---
 .../test-workflow/test-workflow-tabs.tsx      | 25 -------------------
 2 files changed, 7 insertions(+), 28 deletions(-)

diff --git a/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-logs-sidebar.tsx b/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-logs-sidebar.tsx
index 2f5f62c9de2..28c3fcdf56b 100644
--- a/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-logs-sidebar.tsx
+++ b/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-logs-sidebar.tsx
@@ -3,6 +3,7 @@ import { ActivityPanel } from '@/components/activity/activity-panel';
 import { useActivities } from '@/hooks/use-activities';
 import { useEffect, useState } from 'react';
 import { JobStatusEnum } from '@novu/shared';
+import { Loader2 } from 'lucide-react';
 
 interface TestWorkflowLogsSidebarProps {
   transactionId?: string;
@@ -10,7 +11,7 @@ interface TestWorkflowLogsSidebarProps {
 
 export const TestWorkflowLogsSidebar = ({ transactionId }: TestWorkflowLogsSidebarProps) => {
   const [shouldRefetch, setShouldRefetch] = useState(true);
-  const { activities, isLoading } = useActivities(
+  const { activities } = useActivities(
     {
       filters: transactionId ? { transactionId } : undefined,
     },
@@ -39,9 +40,12 @@ export const TestWorkflowLogsSidebar = ({ transactionId }: TestWorkflowLogsSideb
 
   return (
     <aside className="flex h-full w-[500px] flex-col border-l">
-      {isLoading ? (
+      {transactionId && !activityId ? (
         <div className="flex h-full items-center justify-center">
-          <div className="text-foreground-600 text-sm">Loading activity...</div>
+          <div className="flex flex-col items-center gap-4">
+            <Loader2 className="size-8 animate-spin text-neutral-500" />
+            <div className="text-foreground-600 text-sm">Waiting for activity...</div>
+          </div>
         </div>
       ) : activityId ? (
         <ActivityPanel activityId={activityId} onActivitySelect={() => {}} headerClassName="h-[49px]" />
diff --git a/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx b/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
index 2ab75a2f65a..82b4e81efdd 100644
--- a/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
+++ b/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
@@ -71,31 +71,6 @@ export const TestWorkflowTabs = ({ testData }: { testData: WorkflowTestDataRespo
         });
       }
       setTransactionId(newTransactionId);
-      return showToast({
-        variant: 'lg',
-        children: ({ close }) => (
-          <>
-            <ToastIcon variant="success" />
-            <div className="flex flex-col gap-2">
-              <span className="font-medium">Test workflow succeeded</span>
-              <span className="text-foreground-600 inline">
-                Workflow <span className="font-bold">{workflow?.name}</span> was triggered successfully.
-              </span>
-              <Link
-                to={`${LEGACY_ROUTES.ACTIVITY_FEED}?transactionId=${newTransactionId}`}
-                reloadDocument
-                className="text-primary text-sm font-medium"
-              >
-                View activity feed
-              </Link>
-            </div>
-            <ToastClose onClick={close} />
-          </>
-        ),
-        options: {
-          position: 'bottom-right',
-        },
-      });
     } catch (e) {
       toast.error('Failed to trigger workflow', {
         description: e instanceof Error ? e.message : 'There was an error triggering the workflow.',