Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in library #126

Open
plungarini opened this issue Oct 10, 2021 · 4 comments
Open

Warnings in library #126

plungarini opened this issue Oct 10, 2021 · 4 comments
Assignees
Labels
feature request Issue creates (or is related to) a new feature request

Comments

@plungarini
Copy link

Hello guys I'm receiving those two warnings. Can you update the library and let me know please?

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.        

Please update the following components: %s, ClusteredMapView
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state        
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: %s, ClusteredMapView
@39otrebla
Copy link
Member

@plungarini we have a major refactoring in progress which does include switching to Functional Components. That should fix all those warnings. I'll keep you posted.

@39otrebla 39otrebla self-assigned this Dec 15, 2021
@39otrebla 39otrebla added the feature request Issue creates (or is related to) a new feature request label Dec 15, 2021
@Maqsim
Copy link

Maqsim commented Apr 24, 2022

Hey @39otrebla Thanks for you work. I am also waiting for new refactoring

@Badra00
Copy link

Badra00 commented Jun 3, 2022

Hey @39otrebla any news on this?

@dmackinn
Copy link

This package hasn't been updated in 5+ years, is this still planned on being refactored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue creates (or is related to) a new feature request
Projects
None yet
Development

No branches or pull requests

5 participants