From b4778c4d9c3d54df6181983ab9a6fdc51652b716 Mon Sep 17 00:00:00 2001 From: Monica Dinculescu Date: Fri, 9 Jun 2017 21:16:20 -0700 Subject: [PATCH] stop translating 2 letter words to flags --- emoji-translate.js | 6 +++++- package.json | 2 +- test.js | 12 ++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/emoji-translate.js b/emoji-translate.js index fa7daf9b..173fc97b 100644 --- a/emoji-translate.js +++ b/emoji-translate.js @@ -57,7 +57,11 @@ function getAllEmojiForWord(originalWord) { (words && words.indexOf(maybeSingular) >= 0) || (words && words.indexOf(maybePlural) >= 0) || (words && words.indexOf(maybeVerbed) >= 0)) { - useful.push(allEmoji[emoji].char); + // If it's a two letter word that got translated to a flag, it's 99% of the + // time incorrect, so stop doing that. + if (!(word.length == 2 && allEmoji[emoji].category == 'flags')) { + useful.push(allEmoji[emoji].char); + } } } return (useful.length === 0) ? '' : useful; diff --git a/package.json b/package.json index 8e7ad349..3eb91cdb 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "license": "MIT", "homepage": "https://github.com/notwaldorf/emoji-translate#readme", "dependencies": { - "emojilib": "^2.2.1" + "emojilib": "^2.0.0" }, "devDependencies": { "tape": "^4.6.3", diff --git a/test.js b/test.js index 0e945767..2d094c1a 100644 --- a/test.js +++ b/test.js @@ -38,3 +38,15 @@ test('translate', function (t) { t.end(); }); + +test('annoying translations', function(t) { + // these should not be flags. + t.equal('im', translate.translate('im').trim()); + t.equal('in', translate.translate('in').trim()); + t.equal('is', translate.translate('is').trim()); + t.equal('am', translate.translate('am').trim()); + + // hi should work + t.notEqual('hi', translate.translate('hi').trim()); + t.end(); +});