Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: tag and release v1.0.1 #820

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Nov 6, 2023

Release

This would mean tagging e2f4237 as v1.0.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.0.1.

Changes

The code changes compared to v1.0.0 include:

Full Changelog: v1.0.0...e2f4237

Action Requested

Please respond LGTM (approve) or REJECT (request for changes).

Signed-off-by: Shiwei Zhang <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #820 (e2f4237) into release-1.0 (7f8e86c) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           release-1.0     #820   +/-   ##
============================================
  Coverage        63.94%   63.94%           
============================================
  Files               40       40           
  Lines             2291     2291           
============================================
  Hits              1465     1465           
  Misses             700      700           
  Partials           126      126           
Files Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@shizhMSFT
Copy link
Contributor Author

Since v1.0.1 is a patch release, the following feature in the main branch is NOT cherry-picked.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 89c96ef into notaryproject:release-1.0 Nov 7, 2023
5 checks passed
@shizhMSFT shizhMSFT deleted the prep-v1.0.1 branch November 7, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants