Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP timeout threshold is 2 seconds #976

Open
JeyJeyGao opened this issue Jun 25, 2024 · 2 comments
Open

OCSP timeout threshold is 2 seconds #976

JeyJeyGao opened this issue Jun 25, 2024 · 2 comments
Labels
enhancement New feature or request triage Need to triage
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented Jun 25, 2024

What is not working as expected?

The OCSP timeout threshold is hardcoded to 2 seconds, which is not flexible enough. One of our notation customers encounters timeout issues frequently, so we need to provide a way to customize the OCSP timeout threshold.

What did you expect to happen?

provide a way to customize the OCSP timeout threshold

How can we reproduce it?

Do signature verification with a OCSP server that has high latency

Describe your environment

Linux amd64

What is the version of your Notation CLI or Notation Library?

Notation v1.2.0-alpha.1

@JeyJeyGao JeyJeyGao added bug Something isn't working triage Need to triage labels Jun 25, 2024
@yizha1 yizha1 removed the triage Need to triage label Jun 28, 2024
@yizha1 yizha1 added this to the 1.3.0 milestone Jun 28, 2024
@Two-Hearts
Copy link
Contributor

I'd say this is more an enhancement than a bug? Because the '2 second' default threshold is from Notary Project's spec: https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md#ocsp-download

@JeyJeyGao JeyJeyGao added enhancement New feature or request and removed bug Something isn't working labels Jul 22, 2024
@JeyJeyGao
Copy link
Contributor Author

Updated.

@JeyJeyGao JeyJeyGao added the triage Need to triage label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Need to triage
Projects
Status: Todo
Development

No branches or pull requests

3 participants