Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug log should scrub Set-Cookie header in the logs #1104

Closed
JeyJeyGao opened this issue Dec 11, 2024 · 1 comment
Closed

debug log should scrub Set-Cookie header in the logs #1104

JeyJeyGao opened this issue Dec 11, 2024 · 1 comment
Labels
bug Something isn't working triage Need to triage

Comments

@JeyJeyGao
Copy link
Contributor

What is not working as expected?

The Set-Cookie header might contains sensitive information and need to be scrubbed from the debug logs. Although the header will not appear in notation, including it is a good practice.

What did you expect to happen?

Do not log the value of Set-Cookie header

How can we reproduce it?

N

Describe your environment

N

What is the version of your Notation CLI or Notation Library?

1.3.0-rc.1

@JeyJeyGao JeyJeyGao added bug Something isn't working triage Need to triage labels Dec 11, 2024
@JeyJeyGao JeyJeyGao self-assigned this Dec 11, 2024
@JeyJeyGao JeyJeyGao removed their assignment Dec 11, 2024
@JeyJeyGao
Copy link
Contributor Author

notation/internal/trace/transport.go at main · notaryproject/notation

close the issue as it has been handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Need to triage
Projects
Status: Done
Development

No branches or pull requests

1 participant