Adding validation for request input and added more UTs. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteshbandi
requested review from
gokarnm,
JeyJeyGao,
rgnote,
shizhMSFT,
Two-Hearts and
a team
as code owners
Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
force-pushed
the
main
branch
2 times, most recently
from
ae015c3 to
fb1c58a
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
+ Coverage 70.91% 88.60% +17.68%
===========================================
Files 7 7
Lines 196 272 +76
===========================================
+ Hits 139 241 +102
+ Misses 54 26 -28
- Partials 3 5 +2 ☔ View full report in Codecov by Sentry. |
priteshbandi
force-pushed
the
main
branch
4 times, most recently
from
735b149 to
75ce3e0
Compare
priteshbandi
changed the title
Signed-off-by: Pritesh Bandi <[email protected]>
Merged
Two-Hearts
reviewed
Jan 22, 2024
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
JeyJeyGao
approved these changes
Jan 22, 2024
JeyJeyGao
requested changes
Jan 22, 2024
Signed-off-by: Pritesh Bandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log:
plugin.gofromcli/internal/mock/plugin.go→internal/mock/plugin.goto keep all the mocks in one place.