Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracks multiple TODOs in signature package #80

Closed
3 tasks done
priteshbandi opened this issue Jul 11, 2022 · 0 comments · Fixed by #178
Closed
3 tasks done

Tracks multiple TODOs in signature package #80

priteshbandi opened this issue Jul 11, 2022 · 0 comments · Fixed by #178
Assignees
@jondonas
Milestone
RC-2

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented Jul 11, 2022 •
edited by vaninrao10
Loading

  • include external signing plugin's name and version in signing agent.
  • Verify plugin didnot add any additional top level payload attributes.
  • Add tests for this method. NewSignerFromFiles

#77

The associated Linked PullRequest - #178
@dtzar dtzar added this to the RC-1 milestone Jul 22, 2022
@jondonas jondonas mentioned this issue Oct 31, 2022
Merged
@iamsamirzon iamsamirzon moved this from Todo to In Progress in Notary Project Planning Board Nov 3, 2022
@iamsamirzon iamsamirzon linked a pull request Nov 14, 2022 that will close this issue
Add additional header validation for payload #178
Merged
@vaninrao10 vaninrao10 modified the milestones: RC-1, RC-2 Nov 22, 2022
priteshbandi pushed a commit that referenced this issue Dec 5, 2022
@jondonas
Add additional header validation for payload (#178)
0355e8e 
Addresses TODO's tracked in [Issue 80](#80)

- Note that new tests for NewSignerFromFiles were already added back [in September](2bcfd34)
- Validations around no top-level attributes being added are from [5.c.c](https://github.com/notaryproject/notaryproject/blob/main/specs/plugin-extensibility.md#signing-workflow-using-plugin-1) in the spec

Signed-off-by: Jonathan Donas <[email protected]>
Repository owner moved this from In Progress to Done in Notary Project Planning Board Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jondonas jondonas

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
RC-2
Development

Successfully merging a pull request may close this issue.

Add additional header validation for payload jondonas/notation-go
4 participants
@dtzar @priteshbandi @jondonas @vaninrao10