Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlayerSetNickname event #43

Closed
KarlOfDuty opened this issue Nov 20, 2022 · 4 comments
Closed

Add PlayerSetNickname event #43

KarlOfDuty opened this issue Nov 20, 2022 · 4 comments

Comments

@KarlOfDuty
Copy link

  • Player player
  • string oldName
@zabszk
Copy link
Member

zabszk commented Nov 30, 2022

I'm not sure if that event is needed.

First of all nickname can only be set once. It's not possible to change the nickname of the player during the round. And even if someone forces the server to do so, the change will be rejected by all the clients anyway. So there is no need for oldName parameter, because it would be always null.

Furthermore in Online Mode nickname is always set almost directly before calling PlayerJoined event.

So that event would only make sense in Offline Mode, am I right?

@KarlOfDuty
Copy link
Author

I guess, the one who requested it only runs offline servers iirc.

@zabszk
Copy link
Member

zabszk commented Nov 30, 2022

I guess, the one who requested it only runs offline servers iirc.

Currently offline mode is quite broken and that still makes the oldName redundant. Generally after 12.0.0 release we will do auth system rework, it will fix offline mode, rework the permissions system (it will be easily usable by plugins then), badges system, etc... after that rework PlayerJoined will be called after nickname is set in offline mode as well.

For now we may add such event, however it will get deprecated really soon.

@KarlOfDuty
Copy link
Author

Merged into #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants