Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinafore is not just on localhost, but on all interfaces #2310

Open
kescherCode opened this issue Dec 10, 2022 · 4 comments
Open

Pinafore is not just on localhost, but on all interfaces #2310

kescherCode opened this issue Dec 10, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@kescherCode
Copy link

When starting the server for Pinafore using PORT=4002 node server.js, the server is in fact opened on all interfaces, not only localhost:4002.

@kescherCode kescherCode changed the title Pinafore is NOT on localhost, but on all interfaces Pinafore is not just on localhost, but on all interfaces Dec 10, 2022
@nolanlawson nolanlawson added the bug Something isn't working label Dec 10, 2022
@nolanlawson
Copy link
Owner

This would be a backwards-incompatible change. What is your use case for listening only on localhost? Would you be okay with an option to only listen on localhost?

@kescherCode
Copy link
Author

I would've expected it not to listen on all interfaces, especially since for the Docker instruction in the README, it says it listens on localhost.

But yes, an option to only use localhost would be fine.

@NickColley
Copy link
Collaborator

@kescherCode can you give any more detail to what issue this causes you?

@kescherCode
Copy link
Author

Since Pinafore is, from what I can tell, typically not supposed to be exposed on all interfaces, but rather behind a reverse proxy, it would make that port needlessly accessible whenever it's not firewalled off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants