Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 1.0.0-beta.n releases #43

Closed
Savio-Sou opened this issue Nov 25, 2024 · 1 comment
Closed

Add support for 1.0.0-beta.n releases #43

Savio-Sou opened this issue Nov 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Contributor

Savio-Sou commented Nov 25, 2024

Problem

Following noir-lang/noir#6433, Noir releases are now renamed to the new format of 1.0.0-beta.n (i.e. 1.0.0-beta.0, 1.0.0-beta.1...) which noirup currently does not yet support the fetching and installation of them.

Happy Case

Update the script to support the new Noir release naming, specifically:

  1. Running noirup should fetch the latest 0.x.y or 1.0.0-beta.n stable release, whichever is latest
  2. Running noirup -v ... / noirup --version ... should fetch the corresponding 0.x.y or 1.0.0-beta.n release, e.g. noirup -v 1.0.0-beta.0 should fetch 1.0.0-beta.0

Project Impact

Blocker

Blocker Context

Required before announcing 1.0.0-beta.n on socials

Would you like to submit a PR for this Issue?

None

@Savio-Sou Savio-Sou added the enhancement New feature or request label Nov 25, 2024
@Savio-Sou Savio-Sou added this to Noir Nov 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 25, 2024
@TomAFrench
Copy link
Member

Have you tested this? noirup -v 1.0.0-beta.0 works fine.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants