Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible prom-client version conflicts #85

Open
lbeschastny opened this issue Jun 27, 2024 · 0 comments
Open

Possible prom-client version conflicts #85

lbeschastny opened this issue Jun 27, 2024 · 0 comments

Comments

@lbeschastny
Copy link

Hi.

Currently prom-client is added to this package dependencies, but it could lead to serious issues if it's version doesn't match the one used by the service.

Instead, it should be in the package peerDependencies section, ideally with as loose version range as possible.

Something like this should probably work:

  "peerDependencies": {
    "prom-client": "14.x || 15.x"
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant