-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLE GAP/GATT support to the dev-esp32 branch #3473
base: dev-esp32
Are you sure you want to change the base?
Conversation
Fix capitalization of Bluetooth Co-authored-by: Marcel Stör <[email protected]>
I'd like to get this merged -- any more input? |
As I can't assess C code I added Johny as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a BT expert, but on the whole this looks good!
A few comments, and a couple of fixes I'd like to see before merging, but don't wait for me to merge once you've addressed that. Let's get this landed :)
(sorry about the delay, as usual...)
Nice, is there anything else outstanding other than sorting out the merge issues? |
|
||
### Type conversions | ||
|
||
If the `type` value converts a single item, then that will be the value that is placed into the `value` element. If it converts multiple elements, then the elements will be placed into an array that that will be placed into the `value` element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'that' is repeated twice
Fixes #3469
dev
branch rather than for therelease
branch.docs/*
.This is the first pass at BLE support. There is some more tidyup to do, and also enabling it is slightly tricky as it is built on top
of the NimBLE stack -- and I can't find a way to force enable that stack from the Kconfig.
You can startup and shutdown the BLE stack multiple times and it doesn't obviously leak memory.
It seems to work in my test environment.
Interested in comments.