You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a follow up to nodejs/build#353, here's some rough thoughts of what's needed to get the @nodejs-github-bot running. This should probably be documented in the bot repo.
Here's the short story for those lucky enough not to have struggled with this already for any repo inside the nodejs organization: the organization doesn't allow organization wide access to 3rd party GitHub applications, which includes Travis CI. Sadly Travis CI requires such access to work properly; starting build for new PRs and integrating the build status in the bottom of the PR on github.com.
nodejs.org had a functioning Travis CI integration before the nodejs organization decided to restrict 3rd party access. That put us in a weird state where Travis CI would actually pick up all PRs and automatically build them, but wouldn't display the build status in the PR itself. @nodejs-github-bot fixes that by having a GitHub webhook tell it when a PR is opened, and starts polling the Travis CI API to check the result from the build that Travis started itself.
Why bother you with all this boring stuff? Because too get the @nodejs-github-bot running for this repo, we would either (1) have to get this repo in to the same weird Travis CI state as nodejs.org or (2) see if we can trigger builds manually via the Travis CI API.
Option 1 means we would have to grant Travis CI access to the nodejs organization for a minute or two to get the service link created, then turn 3rd part access off again once we see Travis starts building.
Any other options or thoughts are more than welcome.
The text was updated successfully, but these errors were encountered:
As a follow up to nodejs/build#353, here's some rough thoughts of what's needed to get the @nodejs-github-bot running. This should probably be documented in the bot repo.
Here's the short story for those lucky enough not to have struggled with this already for any repo inside the nodejs organization: the organization doesn't allow organization wide access to 3rd party GitHub applications, which includes Travis CI. Sadly Travis CI requires such access to work properly; starting build for new PRs and integrating the build status in the bottom of the PR on github.com.
nodejs.org had a functioning Travis CI integration before the nodejs organization decided to restrict 3rd party access. That put us in a weird state where Travis CI would actually pick up all PRs and automatically build them, but wouldn't display the build status in the PR itself. @nodejs-github-bot fixes that by having a GitHub webhook tell it when a PR is opened, and starts polling the Travis CI API to check the result from the build that Travis started itself.
Why bother you with all this boring stuff? Because too get the @nodejs-github-bot running for this repo, we would either (1) have to get this repo in to the same weird Travis CI state as nodejs.org or (2) see if we can trigger builds manually via the Travis CI API.
Option 1 means we would have to grant Travis CI access to the nodejs organization for a minute or two to get the service link created, then turn 3rd part access off again once we see Travis starts building.
Any other options or thoughts are more than welcome.
The text was updated successfully, but these errors were encountered: