Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] is available #981

Closed
lukeed opened this issue Oct 12, 2024 · 0 comments · Fixed by #982
Closed

[email protected] is available #981

lukeed opened this issue Oct 12, 2024 · 0 comments · Fixed by #982

Comments

@lukeed
Copy link

lukeed commented Oct 12, 2024

See release notes -- all you have to do is change this line to

-- import hexoid from 'hexoid';
++ import { hexoid } from 'hexoid';

I couldn't get the base branch to pass lint or tests, otherwise I would have sent PR.

This release solves issues like:

Sorry about the noise / trouble, but as I'm sure you all are aware & familiar with, the ESM rollout was problematic and (un)fortunately not specific to hexoid.


Aside from the named export change, hexoid added an exports map. Given that your CI here only runs on Node 18+, you may not care, but there are some obscure Node versions (13.0 - 13.7, iirc) that don't work with "exports" maps. However, these users should (1) not be using those versions to start with, they're experimental & super broken (2) these users are 99% likely using webpack or something anyway, which likely bundles everything up and skips Node requires anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant