feat: deploy script conditionally deploys wsteth adapter + add goerli config #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc554e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7 tasks
luketchang
changed the title
luketchang
changed the title
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
a901cbc to
00ac03d
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
2 times, most recently
from
f1617a5 to
022e3ee
Compare
luketchang
force-pushed
the
luke/actual-refund-amnts
branch
from
3a3251d to
099bc9c
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
022e3ee to
acbe2dd
Compare
Sladuca
reviewed
Sep 13, 2023
.changeset/fifty-pens-train.md
Outdated
| "@nocturne-xyz/deploy": minor | ||
| --- | ||
|
|
||
| add goerli config before redeploy, fix regressions in sepolia config |
There was a problem hiding this comment.
what's the regression here?
luketchang
force-pushed
the
luke/wsteth-deploy
branch
3 times, most recently
from
e90f277 to
597708a
Compare
luketchang
force-pushed
the
luke/actual-refund-amnts
branch
from
aab8164 to
884a297
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
597708a to
43763df
Compare
luketchang
force-pushed
the
luke/actual-refund-amnts
branch
from
884a297 to
166a59b
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
43763df to
e95a7f1
Compare
Sladuca
approved these changes
Sep 14, 2023
luketchang
force-pushed
the
luke/actual-refund-amnts
branch
from
166a59b to
376c8d4
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
e95a7f1 to
6e87705
Compare
luketchang
force-pushed
the
luke/wsteth-deploy
branch
from
6e87705 to
fc554e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Need to deploy wsteth adapter to allow protocol to convert weth -> wsteth. Also need goerli config for redeploy because lido and uniswap are on goerli.
Solution
Proof
Deploy script works on local
Site works up until proof gen (joinsplit circuit changed)
https://www.loom.com/share/f1dc795ab33f44aaa02119a5ab4f8741?sid=afa21471-b875-4aef-93bc-6171ff649b7f
PR Checklist