Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs for next time bug shows up #438

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented Sep 7, 2023

Motivation

insertion writer skipped an insertion, don't know why

Solution

  • add more helpful logs so we can get more information on how/why it happened.

changeset is unnecessary

Proof

unnecessary.

PR Checklist

  • added tests
  • updated documentation
  • added changeset if necessary
  • tested in dev/testnet
  • tested site with snap (we haven't automated this yet)
  • re-built & tested circuits if any of them changed
  • updated contracts storage layout (if contracts were updated)

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: fd7f640

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

Sladuca commented Sep 7, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@Sladuca Sladuca marked this pull request as ready for review September 7, 2023 19:46
@Sladuca Sladuca force-pushed the seb/add-logs-to-insertion-writer branch from df49945 to fec30e3 Compare September 11, 2023 00:23
@Sladuca Sladuca requested a review from luketchang September 11, 2023 00:23
@Sladuca Sladuca force-pushed the seb/add-logs-to-insertion-writer branch from fec30e3 to fd7f640 Compare September 12, 2023 17:59
@Sladuca Sladuca enabled auto-merge (squash) September 12, 2023 17:59
@Sladuca Sladuca merged commit 63a9243 into main Sep 12, 2023
2 checks passed
@Sladuca Sladuca deleted the seb/add-logs-to-insertion-writer branch September 12, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants