-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement canon addr sig check circuit, verifier, sdk wrapper #433
Conversation
🦋 Changeset detectedLatest commit: c4d03f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
fbab3c4
to
401848f
Compare
0a6ba02
to
7e9cd19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm to me, there is one comment in circuit though that is misleading and should be fixed
signal input nonceAndSignBit; | ||
|
||
// *** WITNESS *** | ||
// signature on fixed message used to prove knowledge of viewing key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say knowledge of spending key not viewing key
Motivation
Want to prevent people from registering false mappings between ethereum addresses and nocturne canonical addresses in the address registry
Solution
CanonAddrSigCheck
through which client proves they know spend key corresponding to claimed canonical addressProof
https://www.loom.com/share/6f0137f7410e4e968ce09dbff6fa5651?sid=d4217b60-9beb-473c-8bb0-bea591d40f6a
PR Checklist