Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display deposit types to fe-sdk #426

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

panieldark
Copy link
Contributor

@panieldark panieldark commented Aug 22, 2023

Motivation

Nocturne core uses bigint, which does not work well for frontends.

Solution

Convert bigints on deposit interfaces into BigNumber at the fe-sdk layer

Proof

https://www.loom.com/share/2d683c31e41148959968aa901a3554c8

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package
  • Tested in dev/testnet
  • Tested site with snap (we haven't automated this yet)
  • Re-built & tested circuits if any of them changed
  • Updated contracts storage layout (if contracts were updated)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: ef4fd1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nocturne-xyz/frontend-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panieldark
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from retrieve-as-weth-or-eth-fe-sdk to main August 23, 2023 18:07
@panieldark panieldark enabled auto-merge (squash) August 23, 2023 18:22
@panieldark panieldark merged commit 60a70c1 into main Sep 12, 2023
2 checks passed
@panieldark panieldark deleted the 08-22-add_display_deposit_types_to_fe-sdk branch September 12, 2023 16:58
@panieldark panieldark restored the 08-22-add_display_deposit_types_to_fe-sdk branch September 12, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants