merge pre-audit changes into post-audit #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketchang
commented
Aug 10, 2023
luketchang
commented
Aug 10, 2023
luketchang
commented
Aug 10, 2023
* prog(sdk/snap): syncing returns latest synced index (not committed) * chore: changelogs * nits * save syncWithProgress * bump sdk version * fix fe-sdk post-rebase & fix iterator logic * fix e2e tests * rebase, again * dont start syncing until enter loop * merge + fix off by one err * add initial SDK progress to SyncWithProgressOutput * conditionally refetch latestMerkleIndexOnChain in generator * Bump sdk version after changes * bump testnet version * typo * PR feedback --------- Co-authored-by: Luke Tchang <[email protected]> Co-authored-by: Sladuca <[email protected]>
* bump * Update snap.manifest.json
* fix(updater): updater double insertion bug * yarn install * publishhhhh * snap manifest * bump * add retries * remove bull from subtree update * fix e2e tests * fix include array for recovery * await on mutex when submitting * log * dont recover past latest-synced index * fix recovery index again * remove log in test * add some log statements for when that unit test fails * snap manifest * changelog * snap manifest --------- Signed-off-by: Daniel Park <[email protected]> Co-authored-by: Sladuca <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Daniel Park <[email protected]>
* swap 1-liner values * Update yarn.lock * bump subtree-updater's sdk version --------- Signed-off-by: Daniel Park <[email protected]>
* set cap on max parallel provers to avoid OOM * fix some stuff * set max parallel provers * changelog * fix changelog * yarn lock --------- Co-authored-by: Sladuca <[email protected]> Co-authored-by: Luke Tchang <[email protected]>
* Monkey patches * screener src
…#378) * fix(sdk): ensure buffer secs have passed before checking bundler for opdigest in db * fix e2e tests * bump packages * yarn install * bump sdk again * bump stuff again
* fix(updater): updater double insertion bug * fix(sdk): 40% bump gas price * fix(snap): remove custom gas est and leave to sdk to handle * chore: changelogs * fix(fe-sdk): add old 0n gasPrice hardcode
* Snap reuses lastSyncedMerkleIndex if already syncing * update CHANGELOG
* integrate oz relay into bundler * get relayer api key separate from team api keys * realized I was using wrong api key * integrate oz into screener * prog: update updater and test actor with oz relay * remove tx-manager * fix: screener log nonce pre tx * bump subgraph to ed6b11a
* prog(sdk/snap): syncing returns latest synced index (not committed) * chore: changelogs * nits * save syncWithProgress * bump sdk version * fix fe-sdk post-rebase & fix iterator logic * fix e2e tests * rebase, again * dont start syncing until enter loop * merge + fix off by one err * add initial SDK progress to SyncWithProgressOutput * conditionally refetch latestMerkleIndexOnChain in generator * Bump sdk version after changes * bump testnet version * typo * PR feedback * retrieve-deposits * Update run_local.sh * bump fe-sdk * Update yarn.lock * bump packages * check if is outstanding deposit --------- Signed-off-by: Daniel Park <[email protected]> Co-authored-by: Luke Tchang <[email protected]> Co-authored-by: Sladuca <[email protected]>
luketchang
force-pushed
the
luke/rebase-pre-audit-checkpoint
branch
from
41d7c00 to
ff10dcc
Compare
Sladuca
reviewed
Aug 11, 2023
| @@ -0,0 +1,43 @@ | |||
| { | |||
There was a problem hiding this comment.
I see sepolia2 here but not in config if that means anything
There was a problem hiding this comment.
i deleted, its same config contents file anyways
| // ensure it removes all records when it polls op digest from bundler | ||
| // ensure it removes all records when it polls op digest from bundler (mock date to bypass | ||
| // update op digest buffer) | ||
| Date.now = () => { |
There was a problem hiding this comment.
fix infinite loop:
const dateNow = Date.now;
Date.now = () => {
return dateNow() + 60 * 1000;
};
await sdk.updateOptimisticNullifiers();
Date.now = dateNow;
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@nocturne-xyz/frontend-sdk", | |||
| "version": "1.0.49-alpha", | |||
| "version": "1.0.41-testnet", | |||
There was a problem hiding this comment.
Is this version transition intended?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@nocturne-xyz/sdk", | |||
| "version": "1.0.201-alpha", | |||
| "version": "1.0.179-testnet", | |||
There was a problem hiding this comment.
is this intended version transition?
| ? maxArray( | ||
| events.map( | ||
| (event) => | ||
| event.args.startIndex.toNumber() + event.args.numZeros.toNumber() |
There was a problem hiding this comment.
there might be an off-by-one error here, not sure. But if tests pass that's ok for now...
| if [ -n "$pid" ]; then | ||
| echo "Lurking zombie process on 8545, killing process" | ||
| kill $pid | ||
| echo "Killed process $pid ✅. Headshot! 🧟♂️" |
Sladuca
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merge pre and post audit changes together.
Solution
Rebase
pre-audit-checkpointontomain. Notable changes areProof
https://www.loom.com/share/f491ffd608344989be3c34cac9fea88c
PR Checklist