warn instead of throwing on record not found (#624)

* warn instead of throwing on record not found * warn instead of throwing when setting status of non-existent op * changeset
nocturne-xyz · Nov 19, 2023 · 9e63e75 · 9e63e75
1 parent 326fd2b
commit 9e63e75
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/cuddly-turkeys-prove.md b/.changeset/cuddly-turkeys-prove.md
@@ -0,0 +1,6 @@
+---
+"@nocturne-xyz/frontend-sdk": patch
+"@nocturne-xyz/client": patch
+---
+
+log instead of throw on missing op history record
diff --git a/packages/client/src/NocturneDB.ts b/packages/client/src/NocturneDB.ts
@@ -167,7 +167,7 @@ export class NocturneDB {
 
       // if any record is missing, something bad happened
       if (records.some((r) => r === undefined)) {
-        throw new Error("record not found");
+        console.error("missing record in history");
       }
 
       if (!includePending) {
@@ -193,7 +193,10 @@ export class NocturneDB {
     await this.mutex.runExclusive(async () => {
       const record = await this._getHistoryRecord(opDigest);
       if (record === undefined) {
-        throw new Error("record not found");
+        console.warn(
+          "attempting to set status of op whose record has been pruned"
+        );
+        return;
       }
 
       record.status = status;