Skip to content

Commit

Permalink
Lido offchain plugins p1 (#435)
Browse files Browse the repository at this point in the history
* save

* add wsteth adapter plugin and unit test

* export balancer and uniswap ifaces from contracts

* save op-request-plugins new packages, snap failing build

* monorepo builds again after removing __test export from core

* op request builder collects plugin fn proms

* plugins tests pass again with async builder build()

* nit: fix ordering in erc20 plugin fn

* changesets

* fix changeset

* addr comments, clear plugins changelog, change inheritance for unwrap req

* rebase

* prog: separate enqueuing and processing of items so order of actions in op req builder is consistent with actual

* fix redis build issues

* refactor builder, remove joinsplits by asset and metadata and only use at build() step

* fix e2e test build after insertion writer e2e test uses core plugin
  • Loading branch information
luketchang authored Sep 7, 2023
1 parent 77c4063 commit 6abd69b
Show file tree
Hide file tree
Showing 41 changed files with 4,039 additions and 2,384 deletions.
5 changes: 5 additions & 0 deletions .changeset/angry-dolphins-clean.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nocturne-xyz/core": major
---

Split out builder plugins from core, make op request builder build() async, collect array of plugin promises that resolve to unwraps, actions, refunds, and metadata
5 changes: 5 additions & 0 deletions .changeset/fresh-pears-tease.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nocturne-xyz/op-request-plugins": patch
---

split out plugins from core package
6 changes: 6 additions & 0 deletions .changeset/three-rivers-enjoy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@nocturne-xyz/frontend-sdk": patch
"@nocturne-xyz/e2e-tests": patch
---

Update op request builder build() calls to be awaited
2 changes: 1 addition & 1 deletion actors/bundler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"cors": "^2.8.5",
"ethers": "^5.7.2",
"express": "^4.18.2",
"ioredis": "^5.2.4",
"ioredis": "^5.3.1",
"morgan": "^1.10.0",
"winston": "^3.8.2"
},
Expand Down
2 changes: 1 addition & 1 deletion actors/insertion-writer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@nocturne-xyz/persistent-log": "workspace:^",
"commander": "^9.4.1",
"dotenv": "^16.0.3",
"ioredis": "^5.3.2",
"ioredis": "^5.3.1",
"winston": "^3.8.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion apps/snap/snap.manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Nocturne Snap",
"proposedName": "Nocturne Snap",
"source": {
"shasum": "t7UUeyOUMmPyKVAsYiLManWR4FXmCHuu2InSoQB0uos=",
"shasum": "jtV+jy3kDFcfemEvbUHUAXHia0Q5zcNPI4f50w9d1Fg=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
6 changes: 5 additions & 1 deletion packages/contracts/hardhat.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ subtask(TASK_COMPILE_SOLIDITY_GET_SOURCE_PATHS).setAction(
p.includes('SimpleERC20Token') ||
p.includes('SimpleERC721Token') ||
p.includes('SimpleERC1155Token') ||
p.includes('WETH9'),
p.includes('WETH9') ||
p.includes('IBalancer') ||
p.includes('IUniswapV3'),
);
},
);
Expand Down Expand Up @@ -98,6 +100,8 @@ module.exports = {
'SimpleERC721Token',
'SimpleERC1155Token',
'WETH9',
'IBalancer',
'IUniswapV3',
'TestSubtreeUpdateVerifier',
'TransparentUpgradeableProxy',
'ProxyAdmin',
Expand Down
4 changes: 4 additions & 0 deletions packages/contracts/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export type { Versioned } from './src/Versioned';
export type { WETH9 } from './src/WETH9';

export type { WstethAdapter } from './src/WstethAdapter';
export type { IUniswapV3 } from './src/IUniswapV3';
export type { IBalancer } from './src/IBalancer';

export { DepositManager__factory } from './src/factories/DepositManager__factory';
export { Teller__factory } from './src/factories/Teller__factory';
Expand All @@ -37,6 +39,8 @@ export { SimpleERC1155Token__factory } from './src/factories/SimpleERC1155Token_
export { WETH9__factory } from './src/factories/WETH9__factory';

export { WstethAdapter__factory } from './src/factories/WstethAdapter__factory';
export { IUniswapV3__factory } from './src/factories/IUniswapV3__factory';
export { IBalancer__factory } from './src/factories/IBalancer__factory';

export { TransparentUpgradeableProxy__factory } from './src/factories/TransparentUpgradeableProxy__factory';
export { ProxyAdmin__factory } from './src/factories/ProxyAdmin__factory';
Expand Down
67 changes: 0 additions & 67 deletions packages/core/src/operationRequest/Erc20Plugin.ts

This file was deleted.

Loading

0 comments on commit 6abd69b

Please sign in to comment.