Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-llama.sh script failing due to missing hf_lora_dir argument. #7

Open
digitalmonkey opened this issue Apr 8, 2024 · 1 comment

Comments

@digitalmonkey
Copy link

It looks like when I run the build-llama.sh script, it fails here:

File "/home/vng/dev/trt-llm-rag-linux/build.py", line 895, in
args = parse_arguments()
File "/home/vng/dev/trt-llm-rag-linux/build.py", line 549, in parse_arguments
lora_config = LoraConfig.from_hf(args.hf_lora_dir,
TypeError: LoraConfig.from_hf() missing 1 required positional argument: 'trtllm_modules_to_hf_modules'

Looking at the script, the default for args.hf_lora_dir is None, and its not explicitly provided in the build-llama.sh script.
Is this intentional?

@digitalmonkey
Copy link
Author

digitalmonkey commented Apr 8, 2024

ok, it looks like its due to a version mismatch with lora. In lora_manager.py in my version of tensorrt_llm
the method has three parameters instead of two:
def from_hf(cls, hf_lora_dir, hf_modules_to_trtllm_modules,
trtllm_modules_to_hf_modules):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant