Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing state of which extra credit tests are enabled #35

Open
johnvtan opened this issue Jul 6, 2024 · 1 comment
Open

Consider storing state of which extra credit tests are enabled #35

johnvtan opened this issue Jul 6, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@johnvtan
Copy link

johnvtan commented Jul 6, 2024

I think that if I implement an extra credit feature, I'll want those tests enabled every other time I run the test script, especially if later chapters add more tests for old extra credit features (e.g., Ch 7 implements new tests for the goto extra credit from Ch 6).

It would be nice if instead of passing each individual extra credit flag to the script every time I run it, I could run something like

test_compiler --enable-extra-credit goto

That would cause the script to enable the goto tests for all future runs of the script. And then a corresponding --disable-extra-credit flag that would reverse the change.

@nlsandler nlsandler added enhancement New feature or request good first issue Good for newcomers labels Jul 8, 2024
@nlsandler
Copy link
Owner

I like this idea! I think it would be easy enough to store a list of enabled features in an .extra-credit file in the root of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants