From 3957e2843f66e11f44f5579f62e2c218e1d8a607 Mon Sep 17 00:00:00 2001
From: rensink <arend.rensink@utwente.nl>
Date: Wed, 4 Dec 2024 10:40:38 +0100
Subject: [PATCH] Changed test samples to adapt to new default role of rules
 with parameters (viz., possibly condition)

---
 junit/control/abc.gps/a.gpr                       | 7 +++++--
 junit/control/abc.gps/b.gpr                       | 7 +++++--
 junit/control/abc.gps/c.gpr                       | 7 +++++--
 junit/control/abc.gps/d.gpr                       | 7 +++++--
 junit/control/emptyrules.gps/a.gpr                | 7 +++++--
 junit/control/emptyrules.gps/b.gpr                | 7 +++++--
 junit/control/emptyrules.gps/c.gpr                | 7 +++++--
 junit/control/emptyrules.gps/d.gpr                | 7 +++++--
 junit/control/emptyrules.gps/e.gpr                | 7 +++++--
 src/main/java/nl/utwente/groove/grammar/Rule.java | 4 ++--
 10 files changed, 47 insertions(+), 20 deletions(-)

diff --git a/junit/control/abc.gps/a.gpr b/junit/control/abc.gps/a.gpr
index 8fb9c313d..0c7ed1141 100644
--- a/junit/control/abc.gps/a.gpr
+++ b/junit/control/abc.gps/a.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="a">
+    <graph role="rule" edgeids="false" edgemode="directed" id="a">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>125 59 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/abc.gps/b.gpr b/junit/control/abc.gps/b.gpr
index c8d27197d..f12b542d3 100644
--- a/junit/control/abc.gps/b.gpr
+++ b/junit/control/abc.gps/b.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="b">
+    <graph role="rule" edgeids="false" edgemode="directed" id="b">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>85 82 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/abc.gps/c.gpr b/junit/control/abc.gps/c.gpr
index 85964f8bb..2aa0ad3df 100644
--- a/junit/control/abc.gps/c.gpr
+++ b/junit/control/abc.gps/c.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="c">
+    <graph role="rule" edgeids="false" edgemode="directed" id="c">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>135 89 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/abc.gps/d.gpr b/junit/control/abc.gps/d.gpr
index 4256b1407..464df0da7 100644
--- a/junit/control/abc.gps/d.gpr
+++ b/junit/control/abc.gps/d.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="d">
+    <graph role="rule" edgeids="false" edgemode="directed" id="d">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>148 88 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/emptyrules.gps/a.gpr b/junit/control/emptyrules.gps/a.gpr
index d0ce9a43a..283b32f8c 100644
--- a/junit/control/emptyrules.gps/a.gpr
+++ b/junit/control/emptyrules.gps/a.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="a">
+    <graph role="rule" edgeids="false" edgemode="directed" id="a">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>97 60 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/emptyrules.gps/b.gpr b/junit/control/emptyrules.gps/b.gpr
index a488ceb4a..60018e8c0 100644
--- a/junit/control/emptyrules.gps/b.gpr
+++ b/junit/control/emptyrules.gps/b.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="b">
+    <graph role="rule" edgeids="false" edgemode="directed" id="b">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>90 53 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/emptyrules.gps/c.gpr b/junit/control/emptyrules.gps/c.gpr
index 6719a5db6..e26e7bd5c 100644
--- a/junit/control/emptyrules.gps/c.gpr
+++ b/junit/control/emptyrules.gps/c.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="c">
+    <graph role="rule" edgeids="false" edgemode="directed" id="c">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>117 79 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/emptyrules.gps/d.gpr b/junit/control/emptyrules.gps/d.gpr
index b53312e30..71ba245d3 100644
--- a/junit/control/emptyrules.gps/d.gpr
+++ b/junit/control/emptyrules.gps/d.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="d">
+    <graph role="rule" edgeids="false" edgemode="directed" id="d">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>121 81 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/junit/control/emptyrules.gps/e.gpr b/junit/control/emptyrules.gps/e.gpr
index 89a174753..f4f3d7b4a 100644
--- a/junit/control/emptyrules.gps/e.gpr
+++ b/junit/control/emptyrules.gps/e.gpr
@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <gxl xmlns="http://www.gupro.de/GXL/gxl-1.0.dtd">
-    <graph edgemode="directed" edgeids="false" role="rule" id="e">
+    <graph role="rule" edgeids="false" edgemode="directed" id="e">
+        <attr name="actionRole">
+            <string>transformer</string>
+        </attr>
         <attr name="$version">
             <string>curly</string>
         </attr>
@@ -9,7 +12,7 @@
                 <string>91 84 19 19</string>
             </attr>
         </node>
-        <edge to="n0" from="n0">
+        <edge from="n0" to="n0">
             <attr name="label">
                 <string>par:</string>
             </attr>
diff --git a/src/main/java/nl/utwente/groove/grammar/Rule.java b/src/main/java/nl/utwente/groove/grammar/Rule.java
index 2b610732e..e7923e1e2 100755
--- a/src/main/java/nl/utwente/groove/grammar/Rule.java
+++ b/src/main/java/nl/utwente/groove/grammar/Rule.java
@@ -504,9 +504,9 @@ public CheckPolicy getPolicy() {
      * and has zero priority.
      */
     private boolean isPropertyLike() {
-        boolean result = !isModifying() && getPriority() == 0 && getHiddenPars().isEmpty();
+        boolean result = !isModifying() && getPriority() == 0;
         if (result) {
-            result = getSignature().stream().allMatch(v -> !v.isInOnly());
+            result = getSignature().stream().noneMatch(UnitPar::isInOnly);
         }
         return result;
     }