Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vinxi/routes virtual module and hmr #333

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

mdynnl
Copy link
Contributor

@mdynnl mdynnl commented Jul 11, 2024

Fixes solidjs/solid-start#1286 solidjs/solid-start#1473 solidjs/solid-start#1461

I haven't checked out anything other than solid-start caching issue related to above but probably shouldn't break anything.

Copy link

codesandbox bot commented Jul 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 8cbae91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
vinxi Minor
@vinxi/plugin-directives Major
@vinxi/react-server Patch
@vinxi/router Major
@vinxi/server-components Major
@vinxi/server-functions Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 11, 2024

@mdynnl is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mdynnl mdynnl force-pushed the virtual-routes-module branch from f06efbc to 1a6b721 Compare July 11, 2024 22:55
@mdynnl mdynnl force-pushed the virtual-routes-module branch from 1a6b721 to 0f736c3 Compare July 11, 2024 22:57
@ryansolid
Copy link
Collaborator

ryansolid commented Jul 15, 2024

I'm very excited about this change. Only question I have is related to types. Was this approach able to preserve typing. This was important to @nksaraf. I also wanted to ask if we felt this was minor bump worthy. From the description it doesn't sound like it requires any code change on SolidStart's side.

@mdynnl
Copy link
Contributor Author

mdynnl commented Jul 16, 2024

I believe the types should work fine but I've made some more type fixes here and there so not really sure. And yes, this requires no changes on Solid Start's side.

@nksaraf nksaraf merged commit 0883a4d into nksaraf:main Jul 16, 2024
5 of 6 checks passed
@mdynnl mdynnl deleted the virtual-routes-module branch July 16, 2024 16:54
@mdynnl
Copy link
Contributor Author

mdynnl commented Jul 16, 2024

🤦‍♂️ The last two issues didn't match the auto close keyword so need to manually close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Hydration Error Occurs When Adding New Route
3 participants