-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vinxi/routes virtual module and hmr #333
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 8cbae91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@mdynnl is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel. A member of the Team first needs to authorize it. |
f06efbc
to
1a6b721
Compare
1a6b721
to
0f736c3
Compare
I'm very excited about this change. Only question I have is related to types. Was this approach able to preserve typing. This was important to @nksaraf. I also wanted to ask if we felt this was minor bump worthy. From the description it doesn't sound like it requires any code change on SolidStart's side. |
I believe the types should work fine but I've made some more type fixes here and there so not really sure. And yes, this requires no changes on Solid Start's side. |
🤦♂️ The last two issues didn't match the auto close keyword so need to manually close. |
Fixes solidjs/solid-start#1286 solidjs/solid-start#1473 solidjs/solid-start#1461
I haven't checked out anything other than solid-start caching issue related to above but probably shouldn't break anything.