Glitches in Android build system

[ghost]

Hi,

came across some glitches in 'nit/share/libgc/android-setup-libgc.sh' :

• linux-x86_64 is hardcoded in the line 'path="$ANDROID_NDK/toolchains/$tools_dir/prebuilt/linux-x86_64/bin/"' - does not work on 686
• gcc release version is hardcoded in the line 'tools_dirs=( arm-linux-androideabi-4.9 x86-4.9 mipsel-linux-android-4.9)'

The tool_dirs should be obtainable by glob expansion.

Also, there was an unfriendly warning when the source was not from git:
'
$ make android
mkdir -p bin
../../bin/nitc -o bin/calculator14.apk src/android14.nit -D debug
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
src/calculator.nit:18,2--32: Warning: git_revision used outside of a git repository or git binaries not available (git_revision)
app_version(0, 2, git_revision)
^
'
After adjusting the paths the resulting apk works.

[xymus]

The PR #2575 removes the script android-setup-libgc.sh, so the first issue should be "fixed". But sadly, the newer Android NDKs have dropped support for 32 bits platforms. You may be able to get it working by using an older NDK that still supports the new gradle and CMake toolchain.

The second issue is a git error caused by the use of git_revision in client code. You can simply remove git_revision to get rid of it. The original error is scary but useful for developers, I'm not sure how it could be improved, but I'm open to suggestions and PRs.

[ghost]

ok, luckilly I am still using 32 bit host configuration for the support of older systems. Other problem, the Makefile "all" target does not include bin/scientific.. easy enough. Once I add that the dependency checking does not get the dependency on any of the source modules in src/ - nitls -M scientific linux lists only libraries.