Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWI carpet plot assumes a single b0 volume #136

Open
jhlegarreta opened this issue Oct 16, 2024 · 0 comments
Open

DWI carpet plot assumes a single b0 volume #136

jhlegarreta opened this issue Oct 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jhlegarreta
Copy link
Collaborator

What happened?

I may be missing something, an assumption or convention, but the DWI carpet plot assumes that the b0 image has a perfect b-value of 0 s/mm^2 and that there is a single b-value. Often, this is not the case: there might be multiple b-values and the b0 image may have non-zero b-values (e.g. 5 s/mm^2).

So the block starting here
https://github.com/nipreps/nireports/blob/24.0.2/nireports/reportlets/modality/dwi.py#L489

Should be changed to be as general as possible, or else, tell the user to provide the desired b0 value for the normalization.

Although I am using the 24.0.2 release, the block is the same in the current HEAD (67b5f0c)

Else, if what is in place is correct, maybe it should be documented?

I am saying that my data is BIDS-valid, but I am using some single voxel toy data, so it is not BIDS-validated. I spot this looking at the code/debugging some eddymotion code as I needed to call the function.

What command did you use?

N/A

What version of the software are you running?

24.0.2

How are you running this software?

Docker

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

N/A

Additional information / screenshots

N/A

@jhlegarreta jhlegarreta added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant