Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading of bids-filter-file crash on integer/float values #3394

Open
bpinsard opened this issue Nov 8, 2024 · 2 comments
Open

loading of bids-filter-file crash on integer/float values #3394

bpinsard opened this issue Nov 8, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@bpinsard
Copy link
Collaborator

bpinsard commented Nov 8, 2024

What happened?

setting a json bids-filter-file with eg: "inv": 2, will make the following line crash

if not isinstance(value, Query) and 'Query' in value

with

    if not isinstance(value, Query) and 'Query' in value
                                        ^^^^^^^^^^^^^^^^
TypeError: argument of type 'int' is not iterable

What command did you use?

datalad containers-run -n containers/bids-fmriprep -- --fs-license-file freesurfer.license --participant-label 01 --work-dir /tmp --omp-nthreads 8 --nprocs 12 --mem_mb 32000 --output-spaces MNI152NLin2009cAsym T1w:res-iso2mm --cifti-output 91k --output-layout bids --ignore slicetiming --fs-subjects-dir sourcedata/freesurfer --me-output-echos --bids-filter-file code/bids_filters.json --anat-only  ./sourcedata/bids ./ participant

What version of fMRIPrep are you running?

24.1.1

How are you running fMRIPrep?

Singularity

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

@bpinsard bpinsard added the bug label Nov 8, 2024
@effigies
Copy link
Member

effigies commented Nov 8, 2024

Does "2" work? Just trying to figure out how much of a blocker this is.

PR welcome in any case, of course.

@bpinsard
Copy link
Collaborator Author

bpinsard commented Nov 9, 2024

Works with number as string, so really not a blocker, I opened the issue so that if other gets that bug they know where it originates from and I will work on a PR when I find the time.

Also, this is a very experimental run, I was trying to boldly input mp2rage into sMRIPrep, it completes but with a few datasink errors, and it would require to transform the raw image to something that resembles more a T1w.

@bpinsard bpinsard self-assigned this Nov 9, 2024
@effigies effigies added this to the 24.2.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants