Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the /vite-template folder into the /packages folder #121

Open
malparty opened this issue Aug 18, 2022 · 0 comments · May be fixed by #161
Open

Move the /vite-template folder into the /packages folder #121

malparty opened this issue Aug 18, 2022 · 0 comments · May be fixed by #161
Assignees
@bterone
Labels
type : chore
Milestone
3.2.0

Comments

@malparty
Copy link
Member

malparty commented Aug 18, 2022 •
edited
Loading

Why

To be more consistant as we already have the cra-template there.
But be careful, it needs to be ignored by Lerna, otherwise some errors might appear.

Who Benefits?

Developers with a more consistent file structure.
@malparty malparty changed the title Update Move the /vite-template folder into the /packages folder Aug 18, 2022
@malparty malparty mentioned this issue Aug 18, 2022
Merged
7 tasks
@bterone bterone added this to the 3.2.0 milestone Feb 16, 2023
@bterone bterone self-assigned this May 11, 2023
bterone added a commit that referenced this issue May 11, 2023
@bterone
[#121] Move Vite folder to packages
92a0ec7
bterone added a commit that referenced this issue Aug 11, 2023
@bterone
[#121] Update vite initialization to folder for easier updates
36f3d09
bterone added a commit that referenced this issue Aug 11, 2023
@bterone
[#121] Update vite initialization to folder for easier updates
f265315
bterone added a commit that referenced this issue Aug 11, 2023
@bterone
[#121] Update package name in vite template
41db162
bterone added a commit that referenced this issue Aug 11, 2023
@bterone
[#121] Update package name in vite template
1e348f0
bterone added a commit that referenced this issue Sep 28, 2023
@bterone
[#121] Refactor to separate fetching strategies for template generation
574ae8c
bterone added a commit that referenced this issue Sep 28, 2023
@bterone
[#121] Remove lerna CI step
7cfd708
bterone added a commit that referenced this issue Sep 28, 2023
@bterone
[#121] Refactor to separate fetching strategies for template generation
e4abfc6
@bterone bterone linked a pull request Sep 28, 2023 that will close this issue
Open
bterone added a commit that referenced this issue Sep 28, 2023
@bterone
[#121] Remove deprecated lerna bootstrap command
50c031e
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Add test case for testing separate strategies
458ea7a
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Update the package name when initialize vite template
a77fd48
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Update the package name when initialize vite template
3568cda
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Add additonal test scenario
fa93b0b
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Add additonal test scenario
d2e6c4e
bterone added a commit that referenced this issue Sep 29, 2023
@bterone
[#121] Add additonal test scenario
ebbea7e
bterone added a commit that referenced this issue Oct 23, 2023
@bterone
[#121] Refactor usage of then callbacks
9f8df06
bterone added a commit that referenced this issue Oct 23, 2023
@bterone
[#121] Fix CI breakage by setting nimble eslint config version
94ad024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bterone bterone

Labels
type : chore
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

[#121] Move Vite folder to packages nimblehq/react-templates
2 participants
@bterone @malparty