[#191] Add a default database adapter for production environment #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
changed the title
malparty
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hanam1ni,
hoangmirs,
junan,
Lahphim,
longnd and
tyrro
as code owners
|
@hoangmirs @tyrro @Lahphim @junan any comment? :D |
malparty
force-pushed
the
bug/gh-191-add-default-database-adapter-to-build-prod
branch
from
cd3d640
to
60189c6
Compare
andyduong1920
approved these changes
Sep 9, 2022
malparty
deleted the
bug/gh-191-add-default-database-adapter-to-build-prod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Add the DATABASE_URL variable in the docker-assets-precompile script
Insight 📝
All insights are discussed in the issue (#191)
All credits to Hoang for finding a clean fix!!
Proof Of Work 📹
Tested on the EWA-Payroll project (as we already have the CI set up)