Fix install #4491
Merged
Fix install #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handled issue with session encrypted. TODO: install steps check
corentin-soriano
suggested changes
Nov 28, 2024
|
The fix provides minor changes to permit the installation. |
corentin-soriano
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
I just tested, I made some changes (I asked to merge into this branch): #4503
I had a few hangs due to mishandled cases in anti bruteforce, an error after removing the temporary securefile and minor modifications.
Comment on lines
+42
to
+43
| jsonValues = "", | ||
| skFile = ""; |
There was a problem hiding this comment.
Any reason to declare them as var instead of let?
There was a problem hiding this comment.
no, just that it was the case since the begining and did not readjust.
As said all this should be rewritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #4479