Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add */promises implementations #3

Open
niksy opened this issue Sep 27, 2021 · 5 comments
Open

Add */promises implementations #3

niksy opened this issue Sep 27, 2021 · 5 comments
Assignees
@niksy
Labels
enhancement New feature or request

Comments

@niksy
Copy link
Owner

niksy commented Sep 27, 2021

https://twitter.com/kikobeats/status/1399440807711723525?s=12
@niksy niksy added the enhancement New feature or request label Sep 27, 2021
@niksy niksy self-assigned this Sep 27, 2021
@shellscape
Copy link

This one keeps biting us with https://github.com/shellscape/jsx-email

@niksy
Copy link
Owner Author

niksy commented Feb 24, 2024

@shellscape which one specifically? Maybe we can start with some implementation and go from there. We only have timers/promises currently.

@shellscape
Copy link

fs/promises is the one I get hit by most often. fwiw this is mostly to accommodate users which are importing packages which have these deps, and this gets raised at bundle time.

@niksy
Copy link
Owner Author

niksy commented Feb 24, 2024

We can’t really provide anything useful for fs since it can’t really be polyfilled inside browser environment. I think you can alias it to noop in your build process for now.

@shellscape
Copy link

that's what I've done. @jspm/core has a complex take on that. subpath exports to noop would also help here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niksy niksy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shellscape @niksy