Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] Make single source of truth for the version #89

Open
Privat33r-dev opened this issue Apr 30, 2024 · 3 comments
Open

[CD] Make single source of truth for the version #89

Privat33r-dev opened this issue Apr 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Privat33r-dev
Copy link
Collaborator

Currently to update version using CD 2 commands are required:

git tag v2.0.1 main
git push origin v2.0.1

But it causes issues when versions are desynchronized. For example as in this commit: label version is 2.5.3, while the pyproject.toml version is 2.5.2.

Since it's required to have a version in pyproject.toml and it's not flexible, while git tag is optional, I suggest to take version from pyproject.toml and apply it as a git tag. It can be done in github actions, but it would require some workarounds. It's most easily done via git hooks, but they are not automatically shareable for good reasons.

It will allow us to avoid desync issues and streamline version bump for new, as well as existing, contributors.

@Privat33r-dev Privat33r-dev changed the title Make single source of truth for the version [CD] Make single source of truth for the version May 1, 2024
@Privat33r-dev
Copy link
Collaborator Author

@SnoozeThis #97

@SnoozeThis
Copy link

(https://snoozeth.is/eHS7n_Q_l_s) I will wait until #97 is merged and then add a comment.

@SnoozeThis
Copy link

Resolved.

@Privat33r-dev Privat33r-dev added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants