Property with multiple props and property hooks should be a parse error

[ondrejmirtes]

This piece of code:

class Foo
{
    
    public $foo, $bar { get {} }
    
}

Is rejected by PHP with error message: Parse error: syntax error, unexpected token “{”, expecting “,” or “;” in /in/RndUG on line 6

But PHP-Parser does not report syntax error and represents this with an AST.

Multi-props with property hooks are not supported in PHP. I'm asking about this to find out if this should be a parse error in PHP-Parser, or if this is going to be represented with an AST and PHPStan should come with a custom rule to detect it.

Thanks.

[nikic]

I'm fine with having this as a parse error.

[ondrejmirtes]

Thanks. Unfortunately I don't know how to implement this one, grammar is still out of my expertise.

[nikic]

This one wouldn't be checked directly in the grammar, it needs a manual check like the one here:

PHP-Parser/lib/PhpParser/ParserAbstract.php

Lines 1161 to 1167 in 4f9dc8b

	/** @param PropertyHook[] $hooks */
	protected function checkPropertyHookList(array $hooks, int $hookPos): void {
	if (empty($hooks)) {
	$this->emitError(new Error(
	'Property hook list cannot be empty', $this->getAttributesAt($hookPos)));
	}
	}

[ondrejmirtes]

Alright, tried it: #1052

Had to modify the grammar anyway 😅