Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 deprecation warning #1017

Closed
alecpl opened this issue Aug 21, 2024 · 4 comments
Closed

PHP 8.4 deprecation warning #1017

alecpl opened this issue Aug 21, 2024 · 4 comments

Comments

@alecpl
Copy link

alecpl commented Aug 21, 2024

PHP Deprecated:  PhpParser\Parser::parse(): Implicitly marking parameter $errorHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/nikic/php-parser/lib/PhpParser/Parser.php on line 17
@nikic
Copy link
Owner

nikic commented Aug 21, 2024

This was fixed in #984, you're probably using an old version? If you're on 4.x you basically need the very newest version 4.19.1.

@alecpl
Copy link
Author

alecpl commented Aug 21, 2024

I'm running composer with --prefer-lowest (and config.platform.php=8.1) that gave me:

  • phpunit/phpunit (9.6.20)
  • phpunit/php-code-coverage (9.2.31)
  • sebastian/complexity (2.0.0)
  • nikic/php-parser (v4.18.0)

Both php-code-coverage and complexity have minimum set on 4.18. I guess I'll have to force 4.19.1 in my composer.json.

@sebastianbergmann
Copy link
Contributor

I guess I'll have to force 4.19.1 in my composer.json.

Or do not use --prefer-lowest. Anyway: sebastianbergmann/php-code-coverage@2681df1

@alecpl
Copy link
Author

alecpl commented Aug 22, 2024

Thank you guys.

@alecpl alecpl closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants