-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to vite + typescript and add Context #2
Comments
If you have created a branch with migration code, send me a PR, I will merge, I will also suggest you to update README accordingly, and the changes one will have to do to run the project if any. Right now data is in localStorage so can be accessed from anywhere, I have not used context for now, because there arent many components so didn't feel the need to add the extra bit. Right now we can work with localStorage. I will probably change the way I have implemented localStorage logic and use a hook which is there for that specific purpose. |
Hi, I'm on it, I'll create a readme with that. |
Sorry for the late reply, I was busy with other commitments. I understand, please do things you feel necessary or would make your life easier. Create a PR when done. |
Hi, sorry to you as well, I had to finish some things here (since I'll move out of the country in two weeks), I'll work in this, and I'll try to have it before Wednesday. |
As we talked previously I'll migrate to Vite + Typescript the apps. Also I wanted to suggest add Context to manage the state of the exercises globally instead of having it in the list component
The text was updated successfully, but these errors were encountered: